Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executable line analysis fails for declarations with enumerations and unions #974

Closed
davidbyoung opened this issue Dec 23, 2022 · 10 comments
Assignees
Labels

Comments

@davidbyoung
Copy link
Sponsor

Q A
php-code-coverage version 9.2.21
PHP version 8.2.0
Driver Xdebug
Xdebug version (if used) 3.2.0
Installation Method Composer
Usage Method PHPUnit
PHPUnit version (if used) 9.5.27

Here is a scheduled run with 100% code coverage using 9.2.20. The next time it ran with 9.2.21, it reported a drop due to a few interface methods and enum cases incorrectly being included in coverage.

@sebastianbergmann
Copy link
Owner

CC @Slamdunk

@sebastianbergmann
Copy link
Owner

This is likely caused by the changes discussed in #959 and #964.

@Slamdunk
Copy link
Contributor

Thanks for reporting this, I'll propose a fix in the next weeks

@sebastianbergmann
Copy link
Owner

Thank you!

@sebastianbergmann sebastianbergmann changed the title A few interface methods and enum cases are being included in code coverage starting with 9.2.21 Executable line analysis fails for declarations with enumerations and unions Dec 24, 2022
@niconoe-
Copy link

I'm having this issue too so thank you very much @Slamdunk for fixing it very fast! Do you know if this could be released (for instance in a version 9.2.23) soon?

Thanks again!

@Slamdunk
Copy link
Contributor

I don't know, but you can use https://github.com/cweagans/composer-patches in the meantime

@davidbyoung
Copy link
Sponsor Author

Happy new year! 9.2.23 did seem to resolve some of the issues, but I noticed that it's still trying to count interface methods with nullable union types containing enums. Here is the latest Coveralls report with 9.2.23.

@Slamdunk
Copy link
Contributor

Slamdunk commented Jan 1, 2023

Happy new year to you too @davidbyoung #977 😉

@sebastianbergmann
Copy link
Owner

Can this be closed?

@davidbyoung
Copy link
Sponsor Author

It looks like it can. My builds are back to 100%. Thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants