Skip to content

Fix html report. #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2012
Merged

Fix html report. #112

merged 1 commit into from
Sep 19, 2012

Conversation

Domisys
Copy link

@Domisys Domisys commented Sep 19, 2012

In the html report, some tags are not close and others are closed twice.

In the html report, some tags are not close and others are closed twice.
edorian added a commit that referenced this pull request Sep 19, 2012
@edorian edorian merged commit d13c920 into sebastianbergmann:master Sep 19, 2012
@edorian
Copy link
Contributor

edorian commented Sep 19, 2012

Thanks!

@sebastianbergmann
Copy link
Owner

For future reference: Pull Requests for bug fixes should be made against the release branch (1.2). From there the patch can be merged to the branch where new development happens (master). Pull Requests for new features, however, should be made against master.

Thanks!

@Domisys
Copy link
Author

Domisys commented Sep 19, 2012

Ow, ok no problem.

Sorry I didn't read your message soon enough, I just sent another PR.

@edorian
Copy link
Contributor

edorian commented Sep 19, 2012

I though I "backported" this to the 1.2 brach. Ether i forgot to push or the cherry picking didn't work like i expected

@sebastianbergmann
Copy link
Owner

@edorian: In the future, please ask the contributor to send a pull request for the correct branch instead of merging to the wrong branch and then cherry-picking the commit. Thanks!

edorian added a commit that referenced this pull request Sep 19, 2012
@edorian
Copy link
Contributor

edorian commented Sep 19, 2012

@sebastianbergmann I noticed too late (after merging) that 1.2 already existed and then "fixed" it. Usually I do :) Thanks for updating the change log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants