New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to export PHP_CodeCoverage object to .smart format #185

Closed
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@uyga
Contributor

uyga commented Aug 26, 2013

Export and import for PHP_CodeCoverage in our project was too long - approx 70 hours. With changing serialize/unserialize approach we've got 2.5 hours. New approach is var_export and include.

@sebastianbergmann

This comment has been minimized.

Show comment
Hide comment
@sebastianbergmann

sebastianbergmann Aug 26, 2013

Owner

Thank you for your contribution.

I would rather not add an additional logging format/target to PHP_CodeCoverage / PHPUnit but instead, if at all, replace the existing serialize() / unserialize() based solution with your var_export() based one.

Owner

sebastianbergmann commented Aug 26, 2013

Thank you for your contribution.

I would rather not add an additional logging format/target to PHP_CodeCoverage / PHPUnit but instead, if at all, replace the existing serialize() / unserialize() based solution with your var_export() based one.

@sebastianbergmann

This comment has been minimized.

Show comment
Hide comment
@sebastianbergmann

sebastianbergmann Aug 26, 2013

Owner

Can you please open a new pull request that instead of adding a new format changes the implementation of the existing PHP_CodeCoverage_Report_PHP class? Thanks!

Owner

sebastianbergmann commented Aug 26, 2013

Can you please open a new pull request that instead of adding a new format changes the implementation of the existing PHP_CodeCoverage_Report_PHP class? Thanks!

@uyga

This comment has been minimized.

Show comment
Hide comment
@uyga

uyga Aug 26, 2013

Contributor

OK, will do :-)

Contributor

uyga commented Aug 26, 2013

OK, will do :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment