-
-
Notifications
You must be signed in to change notification settings - Fork 384
Enhancement: Run builds with Xdebug 3 #772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Run builds with Xdebug 3 #772
Conversation
Codecov Report
@@ Coverage Diff @@
## master #772 +/- ##
============================================
- Coverage 82.21% 82.18% -0.03%
Complexity 978 978
============================================
Files 58 58
Lines 2963 2964 +1
============================================
Hits 2436 2436
- Misses 527 528 +1
Continue to review full report at Codecov.
|
e62725a
to
f00c23b
Compare
I am sorry to say that this does not work:
Xdebug 3 is not installed for/used with PHP 7.3, PHP 7.4, and PHP 8. Xdebug 2 is not installed for/used with PHP 8. |
We should not even try to use Xdebug 2 on PHP 8 as Xdebug 2 will not support PHP 8. |
7971004
to
ab7e2b9
Compare
52bc8e6
to
345a576
Compare
This should work now. Looks like Xdebug 3 is detected as PCOV: |
345a576
to
870e70d
Compare
870e70d
to
9aa2394
Compare
9aa2394
to
77efb0e
Compare
Thanks to @shivammathur, this works now as expected! 👍 |
Thank you, @sebastianbergmann and @shivammathur! |
This PR
Follows #769 (comment).