Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Document array shapes #991

Merged

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Mar 19, 2023

This pull request

  • documents array shapes
  • runs tools/psalm --config=.psalm/config.xml --set-baseline=.psalm/baseline.xml

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Merging #991 (c76d15e) into main (ef1c71e) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head c76d15e differs from pull request most recent head 122df62. Consider uploading reports for the commit 122df62 to get more accurate results

@@             Coverage Diff              @@
##               main     #991      +/-   ##
============================================
- Coverage     85.18%   85.08%   -0.10%     
- Complexity     1177     1178       +1     
============================================
  Files            69       69              
  Lines          4145     4151       +6     
============================================
+ Hits           3531     3532       +1     
- Misses          614      619       +5     
Impacted Files Coverage Δ
src/CodeCoverage.php 50.00% <ø> (-0.84%) ⬇️
src/Data/ProcessedCodeCoverageData.php 100.00% <ø> (ø)
src/Data/RawCodeCoverageData.php 89.88% <ø> (ø)
src/Driver/XdebugDriver.php 42.85% <ø> (ø)
src/Node/AbstractNode.php 87.50% <ø> (ø)
src/Node/Builder.php 97.77% <ø> (ø)
src/Node/Directory.php 92.71% <ø> (ø)
src/Node/File.php 80.93% <ø> (ø)
src/Report/Xml/Tests.php 100.00% <ø> (ø)
src/StaticAnalysis/CachingFileAnalyser.php 0.00% <ø> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@localheinz localheinz force-pushed the feature/array-shape branch 4 times, most recently from 3f647c8 to f465f57 Compare March 19, 2023 10:37
@localheinz localheinz force-pushed the feature/array-shape branch 21 times, most recently from c9b9ab7 to a19b459 Compare March 19, 2023 17:21
@localheinz localheinz marked this pull request as ready for review March 20, 2023 12:47
Comment on lines -97 to -99
/**
* @psalm-return array{linesOfCode: int, commentLinesOfCode: int, nonCommentLinesOfCode: int}
*/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to AbstractNode.

@localheinz localheinz changed the base branch from main to 10.0 March 20, 2023 13:12
@sebastianbergmann sebastianbergmann merged commit 54be6f2 into sebastianbergmann:10.0 Mar 20, 2023
14 checks passed
@localheinz localheinz deleted the feature/array-shape branch March 20, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants