Skip to content

support for wildcards (glob) in exclude #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tsteur
Copy link
Contributor

@tsteur tsteur commented Oct 9, 2014

Currently, only real paths are allowed. This would allow to exclude paths like /home/project/plugin/*/integration-tests.

Example

This would allow us to define testsuites as follows

   <testsuite name="SystemTests">
        <directory>./System</directory>
        <directory>../../plugins/*/tests</directory>
        <exclude>../../plugins/*/tests/Integration</exclude>
        <exclude>../../plugins/*/tests/Unit</exclude>
    </testsuite>
    <testsuite name="IntegrationTests">
        <directory>./Integration</directory>
        <directory>../../plugins/*/tests/Integration</directory>
    </testsuite>
    <testsuite name="UnitTests">
        <directory>./Unit</directory>
        <directory>../../plugins/*/tests/Unit</directory>
    </testsuite>

Basically, in SystemTests we want to run all tests that were not grouped into Unit or Integration tests as plugins might not follow guidelines to put them into a Unit or Integration directory and to stay backwards compatibility. We would maybe even create a new suite for uncategorized tests or something similar.

With the current behavior we would execute in SystemTests all tests of UnitTests and IntegrationTests as well but we want to exclude them. There can be many plugins which even very from installation to installation and it is therefore not possible to define fixed directories.

Currently, only real paths are allowed. This would allow to exclude paths like `/home/project/plugin/*/integration-tests`
@tsteur tsteur force-pushed the exclude_wildcard_support branch from 4b74625 to c30da2f Compare October 9, 2014 04:19
@mnapoli
Copy link

mnapoli commented Apr 1, 2015

bumping! Please consider merging this little change :)

sebastianbergmann added a commit that referenced this pull request Apr 2, 2015
support for wildcards (glob) in exclude
@sebastianbergmann sebastianbergmann merged commit cb6dfdd into sebastianbergmann:master Apr 2, 2015
mattab added a commit to matomo-org/matomo that referenced this pull request Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants