New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate assertions (and helper methods) that operate on (non-public) attributes #3338

Closed
sebastianbergmann opened this Issue Oct 11, 2018 · 0 comments

Comments

1 participant
@sebastianbergmann
Owner

sebastianbergmann commented Oct 11, 2018

The following methods should be deprecated:

  • assertAttributeContains()
  • assertAttributeNotContains()
  • assertAttributeContainsOnly()
  • assertAttributeNotContainsOnly()
  • assertAttributeCount()
  • assertAttributeNotCount()
  • assertAttributeEquals()
  • assertAttributeNotEquals()
  • assertAttributeEmpty()
  • assertAttributeNotEmpty()
  • assertAttributeGreaterThan()
  • assertAttributeGreaterThanOrEqual()
  • assertAttributeLessThan()
  • assertAttributeLessThanOrEqual()
  • assertAttributeSame()
  • assertAttributeNotSame()
  • assertAttributeInstanceOf()
  • assertAttributeNotInstanceOf()
  • assertAttributeInternalType()
  • assertAttributeNotInternalType()
  • attribute()
  • attributeEqualTo()
  • readAttribute()
  • getStaticAttribute()
  • getObjectAttribute

@sebastianbergmann sebastianbergmann added this to the PHPUnit 8.0 milestone Oct 11, 2018

@sebastianbergmann sebastianbergmann self-assigned this Oct 11, 2018

@sebastianbergmann sebastianbergmann changed the title from Deprecate assertions that operate on (non-public) attributes to Deprecate assertions (and helper methods) that operate on (non-public) attributes Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment