Skip to content

Conversation

millarm
Copy link

@millarm millarm commented May 23, 2014

And refactor duplicated code

@millarm
Copy link
Author

millarm commented May 23, 2014

I didn't like repeating myself in the configuration file. :-)

@sebdah
Copy link
Owner

sebdah commented May 23, 2014

That's a cool feature :). Thanks for the PR. Will test it and merge it.

@sebdah sebdah added this to the 1.15.x milestone May 23, 2014
@sebdah sebdah self-assigned this May 23, 2014
@Jofen
Copy link
Contributor

Jofen commented May 23, 2014

I was thinking of the same thing. Nice feature! :)

Another thing I find is I usually use the same auto scaling rules (i.e. when to scale up/down, how many percentages to scale up/down) for all tables, but just the min/max provisioning for each table is different. The thing I was thinking about is we can separate the scaling rules from table configurations, so tables can share those rulesets.
Also, in that way, we can allow multiple scaling rules per single table. The autoscaling rules can also be simplified as such:
reads last: 5.minutes, greater_than: "90%", scale: { on: :provisioned, by: 2.0 }
reads last: 10.minutes, greater_than: "70%", scale: { on: :provisioned, by: 1.5 }

Just some thoughts to share with. :)

sebdah added a commit that referenced this pull request Jun 2, 2014
sebdah added a commit that referenced this pull request Jun 2, 2014
sebdah added a commit that referenced this pull request Jun 2, 2014
sebdah added a commit that referenced this pull request Jun 2, 2014
sebdah added a commit that referenced this pull request Jun 2, 2014
@sebdah sebdah merged commit 96e4a10 into sebdah:master Jun 2, 2014
@sebdah
Copy link
Owner

sebdah commented Jun 2, 2014

Thanks again for the PR. I have now merged and released it in 1.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants