Allow configurable lookback period instead of the hardcoded 5 minute one #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 31, 2015 17:21
…ple places, and make table.py more consistent with gsi.py
|
Thanks again for your PR. I'm gonna read it though and release it in 2.1.0. Let me think also about the minimum. My experience is also that setting it to 1 does not give any really good / predictable results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully solve #259 however I'm unsure if having lookback-window-start have a minimum of 1 is a good idea, as you usually won't get much data between now()-1 and now(), maybe something like a minimum of 3 would be better so we can guarantee that we would have CloudWatch data. Let me know and I'll change it.