Add customizable equality compare option #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebdah ping |
|
Thanks for this contribution <3! |
|
Hi, would you tag a new release for this update? The latest tag is still v2.5.3. |
|
@iwinux Sorry about that, pushed v2.5.4 now |
renovate bot
referenced
this pull request
in jippi/dottie
Aug 4, 2024
…mod (#68) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/sebdah/goldie/v2](https://togithub.com/sebdah/goldie) | `v2.5.3` -> `v2.5.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sebdah/goldie (github.com/sebdah/goldie/v2)</summary> ### [`v2.5.5`](https://togithub.com/sebdah/goldie/releases/tag/v2.5.5) [Compare Source](https://togithub.com/sebdah/goldie/compare/v2.5.4...v2.5.5) #### What's Changed - Accept sub sub test name for dir by [@​nervo](https://togithub.com/nervo) in [https://github.com/sebdah/goldie/pull/40](https://togithub.com/sebdah/goldie/pull/40) #### New Contributors - [@​nervo](https://togithub.com/nervo) made their first contribution in [https://github.com/sebdah/goldie/pull/40](https://togithub.com/sebdah/goldie/pull/40) **Full Changelog**: sebdah/goldie@v2.5.4...v2.5.5 ### [`v2.5.4`](https://togithub.com/sebdah/goldie/releases/tag/v2.5.4) [Compare Source](https://togithub.com/sebdah/goldie/compare/v2.5.3...v2.5.4) #### What's Changed - Add customizable equality compare option by [@​takashabe](https://togithub.com/takashabe) in [https://github.com/sebdah/goldie/pull/41](https://togithub.com/sebdah/goldie/pull/41) - Don't remove nested subdirectories by [@​adamhicks](https://togithub.com/adamhicks) in [https://github.com/sebdah/goldie/pull/43](https://togithub.com/sebdah/goldie/pull/43) #### New Contributors - [@​takashabe](https://togithub.com/takashabe) made their first contribution in [https://github.com/sebdah/goldie/pull/41](https://togithub.com/sebdah/goldie/pull/41) - [@​adamhicks](https://togithub.com/adamhicks) made their first contribution in [https://github.com/sebdah/goldie/pull/43](https://togithub.com/sebdah/goldie/pull/43) **Full Changelog**: sebdah/goldie@v2.5.3...v2.5.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* */8 * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/jippi/dottie). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this great library.
I've added the WithEqualFn option. By allowing users to use customizable comparison functions, this is particularly useful in scenarios where you don't want to compare the entire file.
This PR resolves #27