When using HTTPS, mixed content on login.html #307
Comments
polytan02
added a commit
to polytan02/cops
that referenced
this issue
Dec 12, 2016
|
I created a pull request for this 👍 |
|
Should this be closed now ? |
|
Will you remake your pull request based on my comment #308 (comment) ? If not I'll do it tonight, I just don't want two people doing the job, it's always frustrating ;) |
|
Thanks @seblucas , your commit looks much better than mine :) |
wikiped
pushed a commit
to wikiped/cops
that referenced
this issue
Jan 9, 2018
* Checked all translations with updateLang and fix all errors. * Fixed css to show filter correctly * Trim leading slash from $_SERVER["SCRIPT_NAME"] so that server side rendered links are relative instead of absolute. * Remove logging * Add getScriptName() method to Link class as suggested by @seblucas (see seblucas#232) Replace references to $_SERVER["SCRIPT_NAME"] with calls to getScriptName() Leaves reference to $_SERVER["SCRIPT_NAME"] in Data:handleThumbnailLink() as it does not inherit from Link * Try the new container based travis * Add the new php version * AlReader HTTP_USER_AGENT Including AlReader HTTP_USER_AGENT URL: AlReader - https://play.google.com/store/apps/details?id=com.neverland.alreader * Including HTTP_USER_AGENT for 3 more android apps Including HTTP_USER_AGENT for android apps FullReader+ https://play.google.com/store/apps/details?id=com.fullreader Reader/2.3.1(java) PocketBook reader https://play.google.com/store/apps/details?id=com.obreey.reader Dalvik/2.1.0 Ebookdroid https://play.google.com/store/apps/details?id=org.ebookdroid org.ebookdroid 2.3.5 regarding issue seblucas#236 * Images for feed categories - new set Images for categories missing from code · Issue seblucas#240 · seblucas/cops - seblucas#240 New set of images created. 64*64 px Tested on Android on light and dark backgrounds Color used: Color Hex #607b8b Light Sky Blue 4 - http://www.color-hex.com/color/607b8b Images are created from flaticon.com You can make new ones online from this links: http://www.flaticon.com/free-icon/user-silhouette_64096 http://www.flaticon.com/free-icon/books-piled-_14184 http://www.flaticon.com/free-icon/buildings_34271 http://www.flaticon.com/free-icon/signing-the-contract_66720 http://www.flaticon.com/free-icon/seo-tags_15564 http://www.flaticon.com/free-icon/abc-book_73353 http://www.flaticon.com/free-icon/small-wall-clock_3921 Creative Commons BY 3.0 Copyright notice for flaticon.com and freepik.com included in Cops (required by icons tool) * Including HTTP_USER_AGENT for ebookDroid Ebookdroid https://play.google.com/store/apps/details?id=org.ebookdroid org.ebookdroid 2.3.5 * Rating icons also for rating details Icons now working on rating details * org\.ebookdroid * Update french anf Hungarian translation from Transifex * Retry to use saucelabs addon from Travis * Fix the addons being there 2 times * As it seems to work, try to update the testing to recent version * Try to replace the sleep by WaitUntil ... * As everything seems to be working fine, let's retry paratest * paratest is still not working. It should be my fault but I really don't why :( * Starting with PHP 5.5, php has an embedded opcache, It may speed up the sauce test * Use a more recent Android version for sauce * Ajout d'une optimisation. On verra * Update the documentation to reflect the real dependencies of COPS (I also updated the web site). fixes seblucas#237 * Fix the détection of bad publication date. fix seblucas#245 The previous one was based on the fact that the PHP version used was 64bits and so the unix timestamp could go way back. With a 32bits PHP that's not the case. Check the notes in http://php.net/manual/en/function.strtotime.php for more information. * Remove the ugly path for java. It's not needed anymore. * Use rawurlencode so that the spaces are remplaced by %20 and not +. Will hopefully help with IIS URL Rewriting * chore: Update the copyright (README) * chore: Switch README to markdown * chore: Remove README.md will be replaced by README * chore: renamed README to README.md (should be better) * chore: remove the email address * chore: advert the docker version. fix seblucas#215 * Add mimetype to most audiobooks formats around. fix seblucas#211 * Add the rewrite rules for IIS. It's still mandatory to install http://www.iis.net/downloads/microsoft/url-rewrite. fix seblucas#249 * Prepare the changelog for the next release * In case the filename contains non ASCII characters then follow rfc6266. fix seblucas#253 This will fix the downloaded filename with Edge, IE11 if it contains a non ASCII character. * Change the way the build matrix is done so that the sauce addon is only enabled when it'll be actually used. * pt-PT edits - language revision pt-PT edits - language revision * Update Localization_pt_PT.json * Fixed typo in * Fixed typo in 'libraries' * Use a cache for resized thumbnails Add the new config parameter $config['cops_thumbnail_cache_directory'] to store resized book's covers. Directory structure is optimized for best performance * Updated .htaccess Only typoes * Added support for custom_column datatype "bool" * Added support for custom_column datatype "rating" * Added a few PHPDoc comments so PHPStorm doesn't show errors * Added support for custom_column datatype "date" * Refactored ColumnTypes into their own classes * Added support for custom_column datatype "integer" * Added support for custom_column datatype "datetime" * fixed PHP pre 5.6 not supporting const arrays * update-lang * UnitTests: Fixed unit tests for folder with spaces in them -> wrapped system call parameters in quotes * Fixed problem with older databases (custom column json has no description field) * PHPDoc comments and a bit of clean up in customcolumn.php * Added support for custom columns in normal list view * Added support for custom columns in book preview (popup panel) * Added support for custom_column datatype "comment" * Updated bootstrap template for use with custom columns * Allow to configure which style is used by default * fixed lowercase letter in language class * Added a few unit tests and fixed two bugs * Added a more unit tests * Added a unit tests * PHPStorm code reformatting * Probably last bunch of test -> 96% coverage for customcolumns.php * Improved performance and memory consumption * Updated german translation file * Fixed customcolumns.php for older php version (5.3) * Fixed scrutinizer issues * Make paths in .gitignore absolute. * Renamed phpunit.xml to phpunit.xml.dist and added minor things. * Use Composer autoloader instead of direct plugin class. * Use jQuery from Composer checkout. * Install stable Composer, install fxp asset plugin, notify Slack. * Windows to Linux line endings. No code change. * Added installation of Composer FXP asset plugin. * Use Composer autoloader where possible. * Get JavaScripts from Bower instead of Packagist. * Windows to Linux line endings. UTF-8 fixes. No code change. * More UTF-8 fixes. No Code Change. * Fix filename case in composer.json. * Drop deprecated PHP versions from Travis. Allow PHPUnit 4.8 for PHP 5.5. * Added specific Scrutinizer config. * Fix PHPUnit tests. * Moved classes into lib/ dir. Split base.php into separate classes. * Code formatting. * Bugfix with missing function from base.php. * Scrutinizer fixes. * Fix Scrutinizer majors. * Some fixes to util.js. * Always try to use LRUCache. Error will throw earlier this way. * Declare Monocle as global for Scrutinizer. * Use window.navigator and window.history instead of directly. * Fix major problem in util.js. (Hopefully.) * Own badges in README. Small fix to transliteration.php. * Split customcolumn.php into classes files. * Code beautify Book.php. * Update changelog * There is some forbidded characters for kepub, so we'll filter them. fix seblucas#264 * Trim the search query it should help with autocomplete on mobile. fix seblucas#272 * Remove php-epub-meta and load via Composer. * Language files line endings back to CRLF (Windows). * fixed authorsName duplicated in templates/default/main * Add Serbian translation. Thanks to Dalibor Vinkic * Update all language file following the custom column merge. * Change the formatting of the language files, based on a suggestion from @horus68. fix seblucas#255 UpdateLang was also updated * Translations 1.0.0 Translations for 1.0 final version. From transifex including new lines. 2 new languages * Fix some translations, there no need for placeholder when no items are here. * Forgot to save after the change in german translation. * Translations - Fix no stars translation updates after master file changes from commit af15b65 * Solving conflits on my repo Updating german file * Update changelog * The next release will be 1.0.0, Yeah ! * Update the changelog * Étiquette 1.0.0 ajoutée à la révision 728d8d2062b2 * Fixed CustomColumnTypeText showing id instead of text when created by getCustomByBook() * Fixed unit tests for custom columns (display text - not id - for text columns) * Fixed wrong htmlvalue bug also for CustomColumnTypeEnumeration * Fix the redirection to the OPDS catalog for Moon+ Reader. reported http://www.mobileread.com/forums/showpost.php?p=3353641&postcount=1292 * Removes "header()" to send as HTML This was causing a PHP error as the output body had already commenced at Line 1 * Déplacement du répertoire /icons dans /images et correction du template * Bootstrap tempate forgotten corrections * Next version will be 1.0.1 * Send the mail as UTF8. fix seblucas#286 * Fix an inconsistancy in checkconfig.php when multiple libraries were used * Switch to a more up to date docker container * Fix custom columns in book list with server side rendering * Fix the tests broken by previous commit, more complicated and will need refactoring later. fix seblucas#288 * Prepare release. * Prepare the automatic build of releases * Étiquette 1.0.1 ajoutée à la révision 87a31fd7b1de * Prepare next release * Fix automatic release zip generation * Update dependencies. * Updated composer.lock. * Fixed "Undefined variable config" in PHP 7. * Updated composer. * Fix config loading order for test. * Improved Polish translation * Fix typo. * Add required PHP extensions to Composer config. * Remove slack notification (at least for now) * Modify all badges to really use this repository. * Fix the mail sender. * This should fix saucelabs * Fix the dependency to LRUCache (we need an older version). Update all other dependencies. * Fixed the link to all COPS contributors. Thanks to horus68 for the report (see seblucas#303). * Seems that the doT directory is in fact dot directory. Should fix sauce. * Android user agent for OPDS reader update Some new user agents and a revised one (all for Android apps) **User Agent was changed by the app** UserAgent: `EBookDroid` Android app: Ebookdroid https://play.google.com/store/apps/details?id=org.ebookdroid **New User Agents** UserAgent: `BookReader` Android app: Gorser Ebookreader - https://play.google.com/store/apps/details?id=com.gorser.ebookreader.epub UserAgent: `CoolReader` Android app: Cool Reader https://play.google.com/store/apps/details?id=org.coolreader UserAgent: `PageTurner` Android app: PageTurner eBook Reader - https://play.google.com/store/apps/details?id=net.nightwhistler.pageturner.ads UserAgent: `books\.ebook\.pdf\.reader` Android app: EBook Reader & PDF Reader - https://play.google.com/store/apps/details?id=books.ebook.pdf.reader Note: it also works with `books.ebook.pdf.reader` UserAgent: `com\.hiwapps\.ebookreader` Android app: Ebook reader (from Hiwapps)- https://play.google.com/store/apps/details?id=com.hiwapps.ebookreader Note: app does not support epub format UserAgent: `OpenBook` Android app: https://play.google.com/store/apps/details?id=app.angeldroid.openbook * Changing cog icon to a magnifying glass Changing cog icon (in the header) to a magnifying glass / search Why? Magnifying glass its usually considered the search button when the Cog is considered a "configuration tool". With actual COPS theme people always ask me "where is the search button"? Note: To play with Search icon size (and make it smaller) see my initial commits to this PR * Avoid mixed content if login is accessed over HTTPS. thanks to polytan02 for the PR. fixes seblucas#307 and seblucas#308 * Update Changelog * Add a mention in config_local.php.example to find all configuration items. fix seblucas#312 * Fix the remaining badges from the README. * Simplify .gitignore and handle cops packages better * Add a chapter in the README to explain how to install from sources. and some small other formatting fixes. * Remove IE9 from sauce (way too old to maintain) * typo fixed (copy paste gone wrong). * Update phing build file with the new composer thing. the ouput gets a lot bigger but if I do somthing about it this file will become a mess. * Update the README a little. Especially to enhance the easiest way to install COPS Small other stuff, nothing big * Fixed the hover effect on the books article (2 or 3 pixel too short on the top). The top margin is already on the cover so there is no need to add it also in the book title. * This should fix travis with PHP 5.5 (and maybe below) * Forgot to add the composer asset plugin in the README * Added caching in the Travis build (should enhance speed) * Updated deps, especially PHPMailer with a Critical Vulnerability See https://github.com/PHPMailer/PHPMailer#security * Added platform in composer to the lowest supported version. That should help in keeping the lock file consistent. * Modified the README.md to add the case of PHP lower than 5.6 Also some small other changes * Fixed full height click on books. fix seblucas#149 * Fix the full height click (introduced in a0137c1). fix seblucas#322 * Modify the mail button's title to include the format that will be sent. re seblucas#326 * Add a configuration item to specify the mail subject. re seblucas#326 * prepare release. re seblucas#323 * Translations updates from Transifex Latest translators work from 2017/03/09 * Copyright year update Updating year to 2017 on the info file! * Update changelog. re seblucas#323 * Update changelog / update Version * Fix the automatic generation of package * Fix the package generated * Étiquette 1.1.0 ajoutée à la révision e61fd2d791c5 * Prepare for next release. * Fix automatic package upload with travis. * Should fix the tests with PHP 5.5. * Try to test PHP 5.4 also. re seblucas#338 * Update sendtomail.php Handling secure smtp ports other that 465. Eg. gmx requires port 587/tls. * Documentation for GMX SMTP configuration Documentation for GMX SMTP configuration * Enhance the docs to show the default value used by the SMTP port if smtp.secure is set * Links to all the docker container versions Linked to x64, armhf, arm64 versions. * Fix COPS Basic Authentication @chadberg figured this one out, I'm just making the PR. @marioscube pointed me to the fix. I can take no credit for this one at all. I have applied the fix locally and it works for me. seblucas#344 seblucas#342 * Update changelog * Translations update 01May2017. Thanks to horus68 * Étiquette 1.1.1 ajoutée à la révision 0c7dc20d311f * Prepare for next release * Fix the automatic generation of package into Github. * Add a section in the README for future contributors. re seblucas#352 Hopefully it will make it clearer and avoid question and issues. * Travis is failing to start PHP server on port 8888, try another one. * Moving PHP embedded server from 8888 to 8080 seems to work ... don't know why * Update the contributing rules to specify that translations should be made through Transifex. re seblucas#357 * Bulgarian translation added * With PHP7 being packaged by default with Ubuntu 16.04, Debian Stretch, adapt the documentation. fix seblucas#359 * Try to update to Trusty image to get hhvm tested again. https://www.travis-ci.org/seblucas/cops/jobs/238686682 * Fix the Debian Stretch installation requirements. fix seblucas#361 Thanks to marioscube for making the test. Also change the styling to make it clearer. * Try to fix travis error (certainly due to the change to npm5) * Try to install it globally * Translation updates - 14-09-2017 Added Indonesia / Chinise (China and Taywan). Removed Chinise (single code) * Update checkconfig output to better help users Specify the old php5 package and the new one Add a mention that using /home for your Calibre directory is not a good idea * Update the dependencies. Notably fix seblucas#365 by bumping seblucas/php-epub-meta to 1.0.1 * Some translation were still with LF instead of CRLF Fix that Transifex give files with CRLF so let's adapt * Update spanish and swedish translation from Transifex * Rename ukrainian translation The official ISO 639 code for Ukraine is uk not ua * Partially fix the download of kepub. Starting with Kobo Firmware 4.7 the embedded browser got smarter and also use Content-Disposition filename to generate the local filename (it also use the full path somehow). Fix the case when following options are enabled : $config['cops_update_epub-metadata'] = "1"; $config['cops_provide_kepub'] = '1'; * Change the PHP version to 7.1 to avoid Scrutinizer crash
dunxd
pushed a commit
to dunxd/mikespub-cops
that referenced
this issue
Sep 10, 2023
…n02 for the PR. fixes seblucas#307 and seblucas#308
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using HTTPS the request for fonts from Google results in a mixed content warning block.
Fix: remove the "http:" from the URL.
<link rel='stylesheet' type='text/css' href='//fonts.googleapis.com/css?family=Open+Sans:400,300italic,800,300,400italic,600,600italic,700,700italic,800italic' />This will result in either an HTTP request from HTTP sites or an HTTPS request fot HTTPS sites.
Alternatively, change the URL to only use HTTPS.
<link rel='stylesheet' type='text/css' href='https://fonts.googleapis.com/css?family=Open+Sans:400,300italic,800,300,400italic,600,600italic,700,700italic,800italic' />The text was updated successfully, but these errors were encountered: