Display book comments at xhtml #491
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all html elements are detected by the preg_match. These comments then displayed with HTML elements visible.
|
Can I ask why is this needed? |
Makes typeahead inputs look like bootstrap3 Reference typeahead css
Make bar take full width only hide labels in sm size use navbar-static-top. no rounded corners remove optional bootstrap theme
change HTML thumbnail size to 225
Fix cover-image CSS - drop height attribute
Needed for client side rendering
Only really needed on XS mobile phone view. Add 3px padding so cover isn't at the very top of display.
Don't just support bootstrap Page redirect
|
Because without it some comments show up like this...
instead of like this
|
array of formats never to return from the database. ORIGINAL_EPUB as an example
Now they won't touch when line wrapping.
return them in JSON
Depends on identifiers branch
|
Included in #522 and release 1.3.0 at https://github.com/mikespub-org/seblucas-cops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert all comments to xhtml