Update fetch.php to lower memory consumption #518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On big eBooks like comic books you can hit the PHP memory limit. With this changes there is no need to raise the memory limit in php.ini. Also readfile is recommended in the php documentation instead of fpassthru for most cases so I changed it. Also if you download binary data make sure that there is no output after that therefore an explicit exit() at the end.
|
Included in #522 and release 1.2.2 at https://github.com/mikespub-org/seblucas-cops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On big eBooks like comic books you can hit the PHP memory limit. With this changes there is no need to raise the memory limit in php.ini. Also readfile is recommended in the php documentation instead of fpassthru for most cases so I changed it. Also if you download binary data make sure that there is no output after that therefore an explicit exit() at the end.