Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: misc nits #73

Closed
wants to merge 3 commits into from
Closed

RFE: misc nits #73

wants to merge 3 commits into from

Commits on Sep 17, 2021

  1. *: remove linux build tag 

    All the files in the package (except the recently added
seccomp_ver_test.go) have linux build tag. Since seccomp is
linux-specific, it does not make much sense to add this build tag,
because this is the only GOOS supported, and it won't compile on any
other platform anyway.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    99d9ad4 View commit details
    Browse the repository at this point in the history

  2. go.sum: tidy 

    Commit 8b6c34e adds go.sum with checksums of some seemingly random
packages. Since libseccomp-golang do not import (use) any of those
packages, these checksums are not required (and are probably leftovers
of running "go get" after cd to this directory).

This commit is a result of "go mod tidy" run.

Fixes: 8b6c34e
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    f0a12ff View commit details
    Browse the repository at this point in the history

  3. *: gofumpt 

    This is a result of running "gofumpt -w *.go" on the source code.

gofumpt[1] is a tool similar to (and based on) gofmt, which adds some
some extra rules for better code formatting. Here, it removes some extra
vertical whitespace, and replaces a var() block with a single element
inside with a mere var declaration. Both make sense.

Enable gofumpt in golangci-lint config to make sure future commits are
gofumpt-ed.

[1] https://github.com/mvdan/gofumpt

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    5178695 View commit details
    Browse the repository at this point in the history