Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commenting in6_ifaceidtomac function behavior #1539

Merged
merged 3 commits into from
Aug 5, 2018

Conversation

MichaelK760
Copy link
Contributor

As said #399 for finish commenting in6_ifaceidtomac in utils6.py

I did my best to explain how the function worked.

I did my best to comment the function behavior as requested on the contribution roadmap
@@ -225,16 +225,21 @@ def in6_ifaceidtomac(ifaceid): # TODO: finish commenting function behavior
is returned on error.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! You can remove the #TODO just above now !

@codecov-io
Copy link

codecov-io commented Jul 27, 2018

Codecov Report

Merging #1539 into master will decrease coverage by 0.39%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #1539     +/-   ##
=========================================
- Coverage   85.39%   84.99%   -0.4%     
=========================================
  Files         177      176      -1     
  Lines       40895    40088    -807     
=========================================
- Hits        34921    34072    -849     
- Misses       5974     6016     +42
Impacted Files Coverage Δ
scapy/utils6.py 86.69% <100%> (ø) ⬆️
scapy/consts.py 69.56% <0%> (-21.74%) ⬇️
scapy/arch/pcapdnet.py 42.58% <0%> (-19.77%) ⬇️
scapy/pton_ntop.py 89.04% <0%> (-8.22%) ⬇️
scapy/arch/__init__.py 87.23% <0%> (-6.39%) ⬇️
scapy/automaton.py 76.3% <0%> (-6.07%) ⬇️
scapy/pipetool.py 84.58% <0%> (-5%) ⬇️
scapy/route.py 84.02% <0%> (-4.87%) ⬇️
scapy/__init__.py 83.33% <0%> (-2.39%) ⬇️
scapy/data.py 81.73% <0%> (-2.18%) ⬇️
... and 13 more

@MichaelK760
Copy link
Contributor Author

All set now!

@gpotter2
Copy link
Member

One last thing: we have some automated PEP8 tests.

Your PR fails with

scapy/utils6.py:232:36: E261 at least two spaces before inline comment
scapy/utils6.py:233:20: W291 trailing whitespace
scapy/utils6.py:234:1: W293 blank line contains whitespace
scapy/utils6.py:237:42: W291 trailing whitespace
scapy/utils6.py:238:55: W291 trailing whitespace

@MichaelK760
Copy link
Contributor Author

Pylint doesn't seem to be giving me any more warnings now

@gpotter2 gpotter2 closed this Aug 5, 2018
@gpotter2 gpotter2 reopened this Aug 5, 2018
@gpotter2 gpotter2 merged commit f5da790 into secdev:master Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants