-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove raw() #1728
Remove raw() #1728
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1728 +/- ##
==========================================
- Coverage 85.59% 78.15% -7.44%
==========================================
Files 181 129 -52
Lines 42133 30542 -11591
==========================================
- Hits 36062 23870 -12192
- Misses 6071 6672 +601
|
I don't get it. Why don't we just add |
What was nice about It’s a case by case :/ We can still set |
I think it would be great if we kept |
f87a146
to
0398d1c
Compare
Can you explain the issue with the current |
It’s slow: we do a try except on so many calls:/ If you |
I understand. What is the improvement compared to the script used in #642 ? |
This needs to be rethink. Dissection is about 8% faster but building is now slower. |
This PR is an old rebase
The
raw
function is supper inefficient, and can quite easily be avoided. It was a bad ideaThis PR comes with an average improvement of dissection speed of 8%
TODO: fix last tests