-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce raw() usage/ compatibility calls + fix cryptography #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great work @gpotter2! Let us know if you need help. |
Codecov Report
@@ Coverage Diff @@
## master #1735 +/- ##
==========================================
- Coverage 85.46% 84.76% -0.71%
==========================================
Files 183 174 -9
Lines 42412 40829 -1583
==========================================
- Hits 36248 34609 -1639
- Misses 6164 6220 +56
|
gpotter2
force-pushed
the
raw-v2
branch
5 times, most recently
from
January 6, 2019 17:34
3bd1d69
to
a236e17
Compare
gpotter2
force-pushed
the
raw-v2
branch
7 times, most recently
from
January 11, 2019 01:47
136c44c
to
a995cae
Compare
guedou
requested changes
Jan 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool PR! See my comments.
gpotter2
force-pushed
the
raw-v2
branch
2 times, most recently
from
January 12, 2019 16:32
255e7b5
to
8dc9ec2
Compare
guedou
approved these changes
Jan 15, 2019
Good to me! @p-l- what is your call? |
Merged
gpotter2
changed the title
Reduce raw() usage + compatibility workarounds
Reduce raw() usage/ compatibility calls + fix cryptography
Feb 1, 2019
gpotter2
force-pushed
the
raw-v2
branch
2 times, most recently
from
February 3, 2019 17:44
43544bb
to
2a31424
Compare
This was referenced Feb 4, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"There is no small job"
This PR:
raw()
calls, that encode packets, frombytes_encode()
calls, that encode text. It's clearer and smally reduces the time it takes to call araw()
. Now we haveraw()
to build packets, andbytes_encode
to get a string to bytes. It’s much cleaner (and faster) and forces us to know exactly what to call wherecmp
callsThis PR also contains a cryptography update
It was found during the implementation
decrypt()
calls to work with latest version of cryptographyTests
Using the version of the benchmarker from #642, with an extra
Results
PS: this will probably fail multiple times on travis