Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor TLS fixes #2767

Merged
merged 6 commits into from
Aug 18, 2020
Merged

Minor TLS fixes #2767

merged 6 commits into from
Aug 18, 2020

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Aug 16, 2020 •
edited
Loading

@codecov
Copy link

codecov bot commented Aug 16, 2020 •
edited
Loading

Codecov Report

Merging #2767 into master will decrease coverage by 0.02%.
The diff coverage is 70.37%.

@@            Coverage Diff             @@
##           master    #2767      +/-   ##
==========================================
- Coverage   88.24%   88.22%   -0.03%     
==========================================
  Files         251      251              
  Lines       53371    53382      +11     
==========================================
- Hits        47096    47094       -2     
- Misses       6275     6288      +13
Impacted Files Coverage Δ
scapy/layers/tls/automaton_cli.py 76.23% <ø> (ø)
scapy/layers/tls/keyexchange.py 86.76% <0.00%> (ø)
scapy/sendrecv.py 86.56% <ø> (-0.17%) ⬇️
scapy/layers/tls/session.py 84.32% <60.00%> (-0.64%) ⬇️
scapy/layers/tls/extensions.py 83.22% <100.00%> (+0.31%) ⬆️
scapy/layers/tls/handshake.py 83.39% <100.00%> (+0.61%) ⬆️
scapy/sessions.py 95.95% <100.00%> (+0.07%) ⬆️
scapy/pton_ntop.py 89.04% <0.00%> (-8.22%) ⬇️
scapy/arch/pcapdnet.py 79.21% <0.00%> (-1.18%) ⬇️
scapy/arch/windows/__init__.py 69.80% <0.00%> (-0.80%) ⬇️
... and 7 more

This was referenced Aug 16, 2020
Closed
Closed
@gpotter2 gpotter2 force-pushed the tls-minor branch 2 times, most recently from f87f75a to a8fb544 Compare August 17, 2020 13:08
@p-l- p-l- merged commit bf0725f into secdev:master Aug 18, 2020
@gpotter2 gpotter2 deleted the tls-minor branch August 18, 2020 14:22
bzalkilani pushed a commit to bzalkilani/scapy that referenced this pull request Jun 14, 2022
@gpotter2 @bzalkilani
Minor TLS fixes (secdev#2767)
29bf145 
* Improve doc

* TLS TCP decompression & small bugs

* Add TLS tests

* Fix issue secdev#2767 2527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-l- p-l- p-l- approved these changes

Assignees
No one assigned
Labels
bug tls
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when getting raw bytes from parsed TLS layer
2 participants
@gpotter2 @p-l-