Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPv6 support on OpenBSD #29

Merged
merged 1 commit into from
Jan 23, 2016
Merged

Fix IPv6 support on OpenBSD #29

merged 1 commit into from
Jan 23, 2016

Conversation

danieljakots
Copy link
Contributor

Hi,

Before

$ scapy
INFO: Can't import PyX. Won't be able to use psdump() or pdfdump().
usage: ifconfig [-AaC] [interface] [address_family] [address [dest_address]]
[parameters]
INFO: No IPv6 support in kernel
WARNING: No route found for IPv6 destination :: (no default route?)
Welcome to Scapy (2.3.2)

$ python2.7 scapy/tools/UTscapy.py -t test/regression.uts -f html -l -o /tmp/scapy_regression_test.html
[...]
PASSED=739 FAILED=28

After

$ scapy
INFO: Can't import PyX. Won't be able to use psdump() or pdfdump().
Welcome to Scapy (2.3.2)

$ python2.7 scapy/tools/UTscapy.py -t test/regression.uts -f html -l -o /tmp/scapy_regression_test.html
[...]
PASSED=750 FAILED=17

It seems to start normally on FreeBSD.

@p-l-
Copy link
Member

p-l- commented Jan 23, 2016

Thanks for reporting & fixing this issue!

If you run the tests as root, do all tests pass? I'm a bit afraid by the FAILED=17!

Will this code work with previous versions of OpenBSD also?

@p-l- p-l- added the bug label Jan 23, 2016
@danieljakots
Copy link
Contributor Author

Thanks for the quick answer :)
Yeah with root: PASSED=759 FAILED=8
The failing tests are the ones which need to be killed:
^Cfailed 11411EF4 Automaton state overloading
^Cfailed A23A30FE Automaton condition overloading
^Cfailed B819945C Automaton action overloading
^Cfailed F047D75C Automaton priorities
^Cfailed A662DF42 Automaton test same action for many conditions
^Cfailed 8E2F0534 Automaton test io event
^Cfailed 0816811E Automaton test io event from external fd
^Cfailed C06AB0CF Automaton test interception_points, and restart

I have the same result (PASSED=748 FAILED=8) with scapy 2.1.0 which we currently have in our ports tree.

For the previous version of OpenBSD, there's no reason that it wouldn't work as the ifconfig format didn't change at lease for the last few releases.

p-l- added a commit that referenced this pull request Jan 23, 2016
Fix IPv6 support on OpenBSD
@p-l- p-l- merged commit 3ecf379 into secdev:master Jan 23, 2016
@p-l-
Copy link
Member

p-l- commented Jan 23, 2016

Thanks!

@p-l-
Copy link
Member

p-l- commented Jan 23, 2016

That automaton tests is something I want to investigate anyway.

@p-l- p-l- mentioned this pull request Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants