Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support x25519 curve in ECDH #2929

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Support x25519 curve in ECDH #2929

merged 1 commit into from
Nov 2, 2020

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 added the tls label Oct 30, 2020
@gpotter2 gpotter2 mentioned this pull request Oct 30, 2020
Closed
@codecov
Copy link

codecov bot commented Oct 30, 2020 •
edited
Loading

Codecov Report

Merging #2929 into master will increase coverage by 0.00%.
The diff coverage is 92.30%.

@@           Coverage Diff           @@
##           master    #2929   +/-   ##
=======================================
  Coverage   87.22%   87.22%           
=======================================
  Files         239      239           
  Lines       52235    52244    +9     
=======================================
+ Hits        45560    45571   +11     
+ Misses       6675     6673    -2
Impacted Files Coverage Δ
scapy/layers/tls/automaton_cli.py 76.00% <ø> (ø)
scapy/layers/tls/keyexchange.py 86.97% <92.30%> (+0.03%) ⬆️
scapy/arch/windows/__init__.py 68.63% <0.00%> (-0.20%) ⬇️
scapy/layers/tls/record.py 91.86% <0.00%> (+1.08%) ⬆️

guedou
guedou reviewed Oct 31, 2020
View reviewed changes
Copy link
Member

@guedou guedou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is it possible to add a test for x448?

@gpotter2
Copy link
Member Author

gpotter2 commented Nov 2, 2020

I don't have a pcap example for those. And honnestly it doesn't seem super necessary

@guedou guedou merged commit ee3829c into secdev:master Nov 2, 2020
@gpotter2 gpotter2 deleted the tls-x25519-ecdh branch November 2, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guedou guedou guedou left review comments

Assignees
No one assigned
Labels
tls
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues while creating TLS connection with x25519 curve set
2 participants
@gpotter2 @guedou