Split #3054: Update of Ecu, EcuResponse, EcuSession and EcuAnsweringMachine. Including typing #3099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3099 +/- ##
==========================================
+ Coverage 85.26% 85.29% +0.03%
==========================================
Files 256 260 +4
Lines 54336 54394 +58
==========================================
+ Hits 46328 46398 +70
+ Misses 8008 7996 -12
|
polybassa
force-pushed
the
EcuRefactorings
branch
from
f9ba4aa
to
dc99130
Compare
|
This PR is ready for review. |
polybassa
force-pushed
the
EcuRefactorings
branch
from
53f562f
to
004f769
Compare
|
@gpotter2 If you find some time, could you please review this PR |
gpotter2
reviewed
Mar 2, 2021
gpotter2
reviewed
Mar 2, 2021
…eringMachine. Including typing
polybassa
force-pushed
the
EcuRefactorings
branch
from
a0f0799
to
a2a13f4
Compare
|
Sorry for bugging you again, but would it be possible to get this PR merged, so I can continue with the split of #3054 |
gpotter2
approved these changes
Mar 8, 2021
bzalkilani
pushed a commit
to bzalkilani/scapy
that referenced
this pull request
Jun 12, 2022
…weringMachine. Including typing (secdev#3099) * Split secdev#3054: Update of Ecu, EcuResponse, EcuSession and EcuAnsweringMachine. Including typing * Update documentation * fix obdscanner tests * Update documentation * update test * update test and docs * make api-doc more nice * update codespell * major cleanup * fix code spell * fix docs build * apply feedback * cleanup * fix typing * fix typing
bzalkilani
pushed a commit
to bzalkilani/scapy
that referenced
this pull request
Jun 14, 2022
…weringMachine. Including typing (secdev#3099) * Split secdev#3054: Update of Ecu, EcuResponse, EcuSession and EcuAnsweringMachine. Including typing * Update documentation * fix obdscanner tests * Update documentation * update test * update test and docs * make api-doc more nice * update codespell * major cleanup * fix code spell * fix docs build * apply feedback * cleanup * fix typing * fix typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new EcuState for further utility objects. This includes refactoring of multiple unit tests, which are based on a AnsweringMachine.
Furthermore, this PR introduces decorators to dynamically extend the protocols UDS and GMLAN with ecu_state and logging functionalities through separated files. This aims to keep the basic protocol description clean, but allows to extend the functionally for certain use cases.