Move libpcap tests to Github Actions #3143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3143 +/- ##
==========================================
- Coverage 85.25% 85.25% -0.01%
==========================================
Files 261 261
Lines 54349 54349
==========================================
- Hits 46336 46334 -2
- Misses 8013 8015 +2
|
guedou
reviewed
Mar 29, 2021
.config/ci/install.sh
Outdated
|
|
||
| # Detect install mode | ||
| if [[ "${1}" == "libpcap" ]]; then | ||
| export SCAPY_USE_LIBPCAP="yes" |
There was a problem hiding this comment.
I think that this does not work. The variable will be removed when install.sh stops.
There was a problem hiding this comment.
You're right, the export is useless. We still need to set it for further below in the script though.
| runs-on: ${{ matrix.os }} | ||
| timeout-minutes: 25 | ||
| timeout-minutes: 20 |
There was a problem hiding this comment.
Why are you decreasing this value?
There was a problem hiding this comment.
I increased it very recently as a workaround for GLMAN tests failing, but it shouldn't be required anymore. You can have a look at the timeouts of this build: we're well under that limit.
guedou
approved these changes
Mar 30, 2021
bzalkilani
pushed a commit
to bzalkilani/scapy
that referenced
this pull request
Jun 12, 2022
* Enable libpcap tests on GHCI * Remove libpcap tests from travis * Reduce GHCI timeout accordingly * Fix libpcap tests * Fix libpcap packet timeout * Remove useless export
bzalkilani
pushed a commit
to bzalkilani/scapy
that referenced
this pull request
Jun 14, 2022
* Enable libpcap tests on GHCI * Remove libpcap tests from travis * Reduce GHCI timeout accordingly * Fix libpcap tests * Fix libpcap packet timeout * Remove useless export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attach_filterfunctions.. root only + pypy tests already are super long due to the build-on-install)It appears that 880d048 has broken libpcap on Linux. This fixes it