Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept list & dict instances as iface= parameter in sniff() #3234

Closed
wants to merge 1 commit into from

Conversation

p-l-
Copy link
Member

@p-l- p-l- commented May 27, 2021

This PR fixes #3191

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #3234 (601a782) into master (fdfb7dc) will decrease coverage by 1.90%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #3234      +/-   ##
==========================================
- Coverage   87.76%   85.85%   -1.91%     
==========================================
  Files         273      269       -4     
  Lines       56042    54831    -1211     
==========================================
- Hits        49183    47077    -2106     
- Misses       6859     7754     +895     
Impacted Files Coverage Δ
scapy/sendrecv.py 83.04% <33.33%> (-4.74%) ⬇️
scapy/arch/linux.py 0.73% <0.00%> (-83.30%) ⬇️
scapy/contrib/cansocket_native.py 16.94% <0.00%> (-76.28%) ⬇️
scapy/layers/tftp.py 40.25% <0.00%> (-56.59%) ⬇️
scapy/contrib/isotp/__init__.py 61.90% <0.00%> (-38.10%) ⬇️
scapy/contrib/automotive/enumerator.py 43.87% <0.00%> (-30.63%) ⬇️
scapy/contrib/automotive/obd/scanner.py 39.41% <0.00%> (-26.81%) ⬇️
scapy/supersocket.py 59.81% <0.00%> (-15.42%) ⬇️
scapy/arch/common.py 76.66% <0.00%> (-15.00%) ⬇️
scapy/contrib/cansocket.py 66.66% <0.00%> (-9.53%) ⬇️
... and 87 more

@p-l-
Copy link
Member Author

p-l- commented May 27, 2021

Duplicate of (fixes the same bug than) #3209

@p-l- p-l- closed this May 27, 2021
@gpotter2
Copy link
Member

It's nicer to use the L2socket of an interface for each interface rather than using one globally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when calling sniff for multiple interfaces
2 participants