Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #359: properly handle ipv6 adresses with multiple zero blocks #395

Closed
wants to merge 3 commits into from
Closed

Fix issue #359: properly handle ipv6 adresses with multiple zero blocks #395

wants to merge 3 commits into from

Conversation

0xb35c
Copy link
Contributor

@0xb35c 0xb35c commented Dec 15, 2016

Fixes #359. IPv6 adresses containing multiple zero blocks are now correctly handled. Also the longest zero block is selected to compact.

@p-l-
Copy link
Member

p-l- commented Dec 16, 2016

Hi,

You should probably rebase your work against current master. Thanks!

@0xb35c
Copy link
Contributor Author

0xb35c commented Dec 16, 2016 •
edited
Loading

Hi,
yeah, sorry for that. Should be fine now?
[edit]
Saw the appveyor test. I'll check that.

@0xb35c
Copy link
Contributor Author

0xb35c commented Dec 28, 2016

Just asking: You did not yet accept the PR yet. Is there a reason for that?

@p-l-
Copy link
Member

p-l- commented Dec 29, 2016

The reason is your PR has not been reviewed yet.

It would be good to add some regression tests to check further changes won't break your code.

Also for your next PR, as I stated in my previous comment, we prefer contributors to git rebase against master rather than git merge, it helps keep the commit history clean.

p-l-
p-l- requested changes Dec 29, 2016
View reviewed changes
Copy link
Member

@p-l- p-l- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add regression tests.

@p-l- p-l- requested a review from guedou December 29, 2016 14:31
@0xb35c
Copy link
Contributor Author

0xb35c commented Dec 31, 2016 •
edited
Loading

I added the regression tests and fixed the code a little bit (not yet pushed). Can you tell me what to do to get you a clean PR? I'm not used to that git magic ;( As I only touched two files it would be ok to start all over again.
Thanks

@0xb35c 0xb35c closed this Dec 31, 2016
@0xb35c 0xb35c deleted the issue_#359 branch December 31, 2016 13:51
@0xb35c 0xb35c mentioned this pull request Dec 31, 2016
Merged
@0xb35c
Copy link
Contributor Author

0xb35c commented Dec 31, 2016

I started over at #431. Somehow screwed my branch up a bit. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-l- p-l- p-l- requested changes

@guedou guedou Awaiting requested review from guedou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xb35c @p-l-