[ExtraFPS] "Brightness (exposure)" slider no longer changes brightness at some locations.

[Dan-Linden]

Test plan

1. Log in with the viewer in test
2. Visit http://maps.secondlife.com/secondlife/Bug%20Island%202/111/30/23
3. Ensure World > Environment is set to Use Shared Environment
4. Open Preferences > Graphics and move the "Brightness (exposure)" slider back and forth and verify the Brightness does not change
5. Open Preferences > Graphics > Advanced Setting and move the Tone Mapping Mix back and forth and verify there is no change.
6. Open Preferences > Graphics > Advanced Setting and change the Tone Mapper between Khronos Neutral and ACES and verify there is no change.

Environment

Second Life Release 7.1.11.11750364439 (64bit)
Release Notes

You are at 111.2, 30.4, 22.9 in Bug Island 2 located at simhost-06a12f8f4413ce859.agni
SLURL: http://maps.secondlife.com/secondlife/Bug%20Island%202/111/30/23
(global coordinates 260,463.0, 249,374.0, 22.9)
Second Life Server 2024-10-15.11356152186
Release Notes

CPU: Intel(R) Core(TM) i7-5930K CPU @ 3.50GHz (3491.91 MHz)
Memory: 32610 MB
OS Version: Microsoft Windows 10 64-bit (Build 19045.5131)
Graphics Card Vendor: NVIDIA Corporation
Graphics Card: NVIDIA GeForce GTX 1080/PCIe/SSE2

Windows Graphics Driver Version: 32.0.15.6590
OpenGL Version: 4.6.0 NVIDIA 565.90

Window size: 1770x1257
Font Size Adjustment: 96pt
UI Scaling: 1
Draw distance: 128m
Bandwidth: 3000kbit/s
LOD factor: 1.75
Render quality: 5
Texture memory: 8192MB
Disk cache: Max size 1638.4 MB (100.0% used)

J2C Decoder Version: KDU v7.10.4
Audio Driver Version: OpenAL, version 1.1 ALSOFT 1.23.1 / OpenAL Community / OpenAL Soft: OpenAL Soft
Dullahan: 1.14.0.202408091639
CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54
Chromium: 118.0.5993.54
LibVLC Version: 3.0.21
Voice Server Version: Not Connected
Packets Lost: 9/13,172 (0.1%)
November 21 2024 16:27:53

Description

"Brightness (exposure)" slider doesn't work on Bug Island 2

Reproduction steps

1. Log in with the ExtraFPS 7.1.11.11750364439 viewer (https://releasenotes.secondlife.com/viewer/7.1.11.11750364439.html)
2. Visit http://maps.secondlife.com/secondlife/Bug%20Island%202/111/30/23
3. Ensure World > Environment is set to Use Shared Environment
4. Open Preferences > Graphics and move the "Brightness (exposure)" slider back and forth.

Observed: Nothing happens on ExtraFPS 7.1.11.11750364439. Personal lighting > Reflection Probe Ambiance = 0.00

Expected; The environment should get darker and lighter, as in DeltaFPS 7.1.10.10800445603. Personal lighting > Reflection Probe Ambiance = 0.01

Note 1: This may be due to #2632 but I'm not sure.
Note 2: Is the real issue that Personal lighting at that location shows Reflection Probe Ambiance = 0.01 in DeltaFPS and 0.00 in ExtraFPS?

[kylelinden]

DeltaFPS had auto adjust so the 0.01 data was accurate.
ExtraFPS now does not have auto adjust so 0.00 is now accurate.

[valeriiaaproductengine]

Failed QA.

Now, when scrolling the "Brightness (exposure)" slider back and forth, the environment changes accordingly.
But when changing other parameters(the Tone Mapping Mix, the Tone Mapper between Khronos Neutral and ACES ), the changes are still not visually visible.

Verified on the Second Life Release 7.1.11.12041172537 (64bit) on Win10/OSX on http://maps.secondlife.com/secondlife/Bug%20Island%202/111/30/23 location in the scope of https://github.com/secondlife/iqa/issues/401.

[Geenz]

Tone mapping is not supported on legacy skies.

[AtlasLinden]

As given by Geenz's comment, Tone Mapper and Exposure settings will no longer work on legacy skies (skies with Reflection Probe Ambiance = 0).

With newly created skies this is verified. However, on multiple regions that previously had a legacy sky applied (including Bug Island and multiple randomly selected mainland regions), the exposure setting is still making changes as given by Valeriia's comment above.
The Tonemapper settings are not visible (also mentioned in above comment)

[kylelinden]

Gray out the slider when not available.

[DmitrySProductengine]

Failed QA.
Verified on the Second Life Release 7.1.11.12150664210 (64bit) on Win11/OSX in the scope of IQA #404.

According to the test plan for this ticket - Brightness should not change when changing the "Brightness (exposure)" slider value.

Currently, the behavior is the same as described by Valeria:

1. Moving the "Brightness (exposure)" slider back and forth - the Brightness is changing.
2. Moving the Tone Mapping Mix back and forth - no changes.
3. Changing the Tone Mapper between Khronos Neutral and ACES - no changes.

See the attached video:

Actual.-.7.1.11.12150664210.-.OSX.mp4

But in the Description, Expected result in reproduction steps it is indicated that the brightness should change.
Could you please review the entire ticket and adjust it to the required behavior?
At the moment, my decision to fail is based on the specified test plan.

[Dan-Linden]

This may be fixed by the patch for https://github.com/secondlife/viewer-private/issues/329

[igorlproductengine]

Passed QA.
Verified on the Second Life Release 7.1.12.12682568132 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/423.

Currently, behavior is according to the test plan:

1. Moving the "Brightness (exposure)" slider back and forth - no changes.
2. Moving the Tone Mapping Mix back and forth - no changes.
3. Changing the Tone Mapper between Khronos Neutral and ACES - no changes.