Improvements found in reviewing mac_arm branch #4629 #4657

brad-linden · 2025-09-10T20:09:46Z

Description

Minor Improvements found while reviewing mac_arm branch #4629

Followups related to #4392

Please ensure the following before requesting review:

I have provided a clear title and detailed description for this pull request.
If useful, I have included media such as screenshots and video to show off my changes.
The PR is linked to a relevant issue with sufficient context.
I have tested the changes locally and verified they work as intended.
All new and existing tests pass.
Code follows the project's style guidelines.
Documentation has been updated if needed.
Any dependent changes have been merged and published in downstream modules
I have reviewed the contributing guidelines.

brad-linden · 2025-09-10T20:22:04Z

indra/newview/llappviewer.cpp

 #if defined(LL_X86) || defined(LL_X86_64)
    asm ("int $3");
+#else
+    __builtin_trap();


this might not be quite right. I'm not sure that the debugger would be able to resume after this intrinsic

Improvements found in reviewing mac_arm branch #4629

f98a61b

brad-linden requested a review from a team September 10, 2025 20:09

github-actions bot added c/cpp cmake llwindow llcommon llkdu labels Sep 10, 2025

brad-linden commented Sep 10, 2025

View reviewed changes

akleshchev requested a review from Geenz September 10, 2025 20:32

akleshchev assigned callumlinden Sep 10, 2025

Geenz merged commit 3ab18e8 into release/2025.07 Sep 10, 2025
12 checks passed

Geenz deleted the brad/mac_universal branch September 10, 2025 23:08

github-actions bot locked and limited conversation to collaborators Sep 10, 2025