#4757 Model uploader warning when physics library is missing #4780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR implements a warning system for the model uploader when physics library functionality is missing, addressing issue #4757. The changes provide platform-specific guidance to help users resolve the missing physics library issue.
- Adds two new notification dialogs: one with Apple Silicon workaround instructions and one with general warning
- Implements conditional logic to check physics library availability and show appropriate warnings
- Maintains model preview functionality on non-Apple platforms even when physics library is missing
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| indra/newview/skins/default/xui/en/notifications.xml | Adds two new notification templates for missing physics library warnings |
| indra/newview/llviewermenufile.cpp | Implements conditional check for physics library and shows appropriate warning based on platform |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
akleshchev
force-pushed
the
andreyk/viewer_4757
branch
from
6e248f0 to
94fd570
Compare
Geenz
approved these changes
Oct 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show a warning with workaround on mac and general warning for everything else.
For now without 'more info' link, will be added once link becomes available.