Skip to content

Clean Code #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jan 26, 2024
Merged

Clean Code #110

merged 17 commits into from
Jan 26, 2024

Conversation

Weltraumschaf
Copy link
Member

No description provided.

@Weltraumschaf
Make abstract class package private to hide implementation details
211898a 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf Weltraumschaf self-assigned this Jan 19, 2024
@Weltraumschaf Weltraumschaf added the enhancement New feature or request label Jan 19, 2024
@Weltraumschaf
Remove unused import
572bc24 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
Simplified condition
6d7058f 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
In Java enums are named upper case
3b865e6 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
Make protected field final
41568ea 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
Clean up streaming code
639ee31 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
Remove unused import
14608e5 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
Remove unused import
610f32c 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
Remove code clutter
f025b08 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
Use constant for repeated API URL prefix
d631118 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
Reformatting
14b4caa 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
Fix constant
57fa88e 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
Remove deprecated API
7db682f 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
Reformatting
a98466f 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
Simplify condition
d8a6404 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
Redocue visibility
89ea42f 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
Reformatting
9a42aa4 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@J12934 J12934 self-requested a review January 26, 2024 10:28
J12934
J12934 approved these changes Jan 26, 2024
View reviewed changes
@Weltraumschaf Weltraumschaf merged commit 67f9f52 into secureCodeBox:main Jan 26, 2024
@Weltraumschaf Weltraumschaf deleted the clean_code branch January 26, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J12934 J12934 J12934 approved these changes

Assignees

@Weltraumschaf Weltraumschaf

Labels
enhancement New feature or request
Projects
secureCodeBox
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Weltraumschaf @J12934