Add ncrack scanner implementation #88
Conversation
scanners/ncrack/.helmignore
Outdated
|
|
||
| parser/ | ||
| scanner/ | ||
| examples/ |
There was a problem hiding this comment.
This file should end with a newline as recommended by GitHub
| - -v | ||
| - --user=root,admin | ||
| - --pass=THEPASSWORDYOUCREATED,12345 | ||
| - ssh://dummy-ssh |
There was a problem hiding this comment.
This file should end with a newline as recommended by GitHub
scanners/ncrack/parser/.dockerignore
Outdated
| @@ -0,0 +1 @@ | |||
| node_modules/ | |||
There was a problem hiding this comment.
This file should end with a newline as recommended by GitHub
scanners/ncrack/parser/.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| node_modules/ | |||
There was a problem hiding this comment.
This file should end with a newline as recommended by GitHub
| <address addr="45.33.32.156" addrtype="ipv4"/> | ||
| <port protocol="tcp" portid="80" name="http"></port> | ||
| </service> | ||
| </ncrackrun> |
There was a problem hiding this comment.
This file should end with a newline as recommended by GitHub
scanners/ncrack/values.yaml
Outdated
|
|
||
| scannerJob: | ||
| resources: {} | ||
| # scannerJob: |
There was a problem hiding this comment.
Is there a reason these lines have to be commented out?
There was a problem hiding this comment.
This is done in all scanners and recommended by helm.
Basically don't impose resource restrictions by default but give users the ability to configure them on their own.
| ); | ||
| }, | ||
| 3 * 60 * 1000 | ||
| ); |
There was a problem hiding this comment.
This file should end with a newline as recommended by GitHub
| }, | ||
| ] | ||
| `); | ||
| }); |
There was a problem hiding this comment.
This file should end with a newline as recommended by GitHub
| "description": "Parses result files for the type: 'ncrack-xml'", | ||
| "main": "", | ||
| "scripts": {}, | ||
| "keywords": [], |
There was a problem hiding this comment.
Should we define some useful keywords?
| protocol: protocol, | ||
| service: portName, | ||
| username, | ||
| password, |
There was a problem hiding this comment.
I'm not sure if we should include the password.
There was a problem hiding this comment.
I think this needs to be in here because otherwise you can't really confirm that it was properly identified.
But its probably a good idea to write this in the docs for ncrack that users need to consider this.
Missing: