Added MakeFile to run all hook and scanner tests #1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
RamiSouai
added
maintenance
testing
To install node deps from /scanners instead of /tests/integration Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Weltraumschaf
requested changes
Mar 16, 2022
|
|
||
| integration-tests: | ||
| for dir in $(wildcard */.); do \ | ||
| $(MAKE) integration-tests -C $$dir;\ |
There was a problem hiding this comment.
Not sure if we need quoting for variable dir to prevent possible word splitting ("$$dir").
|
|
||
| integration-tests: | ||
| for dir in $(wildcard */.); do \ | ||
| $(MAKE) integration-tests -C $$dir;\ |
There was a problem hiding this comment.
Not sure if we need quoting for variable dir to prevent possible word splitting ("$$dir").
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
Weltraumschaf
previously approved these changes
Mar 21, 2022
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
rseedorff
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rami Souai rami.souai@iteratec.com
Description
Part of #1027. Adds a new Makefile in /scanners and /hooks so that when in these directories, the command make integration-tests runs all the tests in the respective subdirectories.
Checklist
npm testruns for the whole project.