Fixes the tests of Trivy and adds a check for empty scanResults #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ilyesbdlala
changed the title
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| eslint | 2 | 1 | 0.63s | ||
| ✅ JSON | eslint-plugin-jsonc | 1 | 0 | 1.16s | |
| ✅ SPELL | misspell | 3 | 0 | 0.04s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
Trivy tests have been ruuning incorrectly until now. The JSON.parse function was missing, that means the tests for empty results was succesfful because of the earlier check of "if the results are a string or not" and not the check of "results is an non-empty array" This fixes that. Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala
force-pushed
the
fix/trivy-empty-results
branch
from
1457524 to
2cddb2c
Compare
4 tasks
J12934
approved these changes
Jul 10, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trivy tests have been ruuning incorrectly until now. The JSON.parse function was missing, that means the tests for empty results was succesfful because of the earlier check of "if the results are a string or not" and not the check of "results is an non-empty array" This fixes that.
closes #1489
Checklist