Skip to content

Allowed Specifying Labels for Pods of Scans #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2023
Merged

Allowed Specifying Labels for Pods of Scans #1899

merged 2 commits into from
Sep 12, 2023

Conversation

Ilyesbdlala
Copy link
Member

Description

closes #1776

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

Ilyesbdlala and others added 2 commits September 5, 2023 16:33
@Ilyesbdlala
#1776 Added a util function to allow merging two string maps
603daa9 
Co-authored-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
#1776 merged labels from scan CRD with the parse/scan job labels
0aa471a 
Co-authored-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala added the enhancement New feature or request label Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023 •
edited
Loading

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ GO golangci-lint 4 1 1.1s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@Zero3141 Zero3141 requested a review from J12934 September 5, 2023 14:47
@Ilyesbdlala Ilyesbdlala merged commit b31843c into main Sep 12, 2023
@Ilyesbdlala Ilyesbdlala deleted the feature/scan-pod-labels branch September 12, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J12934 J12934 J12934 approved these changes

Assignees

@Zero3141 Zero3141

@Ilyesbdlala Ilyesbdlala

Labels
enhancement New feature or request
Projects
secureCodeBox
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow To Specify Labels for Pods of Scans
3 participants
@Ilyesbdlala @J12934 @Zero3141