Fix Issue with nuclei parser issue for dns related findings #3153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… do not have portnumbers in their hostname Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
✅ Deploy Preview for docs-securecodebox canceled.
|
scanners/nuclei/parser/parser.js
Outdated
| @@ -99,10 +99,17 @@ function parseHostname(host) { | |||
| } | |||
|
|
|||
| try { | |||
| const url = new URL(host); | |||
| // If the host doesn't have a protocol, add one to make URL parsing work | |||
| const urlString = host.includes("://") ? host : `http://${host}`; | |||
There was a problem hiding this comment.
At least in my browser an URL like www.example.com:// is valid. I suggest to check for ^http(s)://.
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
|
Weltraumschaf
approved these changes
Jul 31, 2025
github-project-automation
bot
moved this from To Review
to Reviewer Approved
in secureCodeBox
github-project-automation
bot
moved this from Reviewer Approved
to Done
in secureCodeBox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Issue with nuclei parser not working properly with findings which do not have portnumbers in their hostname
Checklist