Support initContainers in cascading scan rules #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support initContainers (ADR-0009) in cascading scans, we need to add a flag for them to the CRDs to be consistent with the volumes, env, etc. Signed-off-by: Max Maass <max.maass@iteratec.com>
The hook code needs explicit support for passing through, merging, and templating init containers for cascading scans correctly. This commit adds this support, together with test cases. Signed-off-by: Max Maass <max.maass@iteratec.com>
malexmave
added
architecture
malexmave
commented
Oct 15, 2021
Comment on lines
+196
to
+201
| cascadingRule.spec.scanSpec.initContainers = initContainers | ||
| if (cascadingRule.spec.scanSpec.initContainers !== undefined) { | ||
| cascadingRule.spec.scanSpec.initContainers.forEach(container => { | ||
| container.command = container.command.map(parameter => Mustache.render(parameter, templateArgs)) | ||
| }); | ||
| } |
There was a problem hiding this comment.
If someone has a nicer way of doing this, feel free to make a suggestion / change it in the branch.
J12934
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When adding support for init containers (ADR-0009) to the scan definitions, I did not realize that the cascading scan rules needed to get explicit support for this as well. So, with this PR I added:
Checklist
npm testruns for the whole project.