Fix Issue in Helm Release Process #753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The charts in there are example which should not be published
rseedorff
approved these changes
Oct 22, 2021
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #752
Helm Chart release pipeline was failing for release 3.2.0, this was fixed after the fact by hand by uploading the missing charts manually. It seems that in that process the charts we package slightly incorrectly so that they contained nested .tgz of the chart contents which dramatically increased their size causing installation issues for some of the charts.
This PR should resolve the issues with the release pipeline. Which should ensure that the charts are build automatically and correctly in the next release.
Tested this by running the script locally (thought with the pushing to the registry disabled) and the script skipped the .templates folder correctly
Checklist
npm testruns for the whole project.