Skip to content

Conversation

SequeI
Copy link
Collaborator

@SequeI SequeI commented Sep 4, 2025

Summary by Sourcery

Prepare the model-validation-operator for the 0.0.1-techpreview release by updating CSV metadata, switching default images to Red Hat registry digests, and adding a Makefile target for image overrides.

Enhancements:

  • Bump ClusterServiceVersion to v0.0.1-techpreview and update maturity to tech-preview
  • Update CSV metadata with support annotations, feature flags, repository URL, and provider information

Build:

  • Switch operator image in Makefile and Kustomize overlay to registry.redhat.io with specific digests
  • Add a dev-images Makefile target for swapping to development image references

Chores:

  • Update internal default ModelTransparencyCliImage to use Red Hat registry digest

Copy link

sourcery-ai bot commented Sep 4, 2025

Reviewer's Guide

This PR prepares the operator for a v0.0.1 release by overhauling CSV metadata (version, maturity, annotations, provider) and standardizing image references to the Red Hat registry with digest support, plus adding a ‘dev-images’ Makefile helper.

File-Level Changes

Change Details Files
Overhaul CSV manifest metadata for release
  • Bump operator version to v0.0.1 and change maturity to tech-preview
  • Add containerImage, feature flags, repository, support, and subscription annotations
  • Update provider name to Red Hat, version suffix, punctuation, and maintainer entries
config/manifests/bases/model-validation-operator.clusterserviceversion.yaml
Standardize images and add development helper
  • Switch IMG and kustomization images to registry.redhat.io with SHA digests
  • Add ‘dev-images’ target in Makefile for local image substitution
  • Update default CLI image constant to use registry.redhat.com digest
Makefile
config/overlays/olm/kustomization.yaml
internal/constants/images.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • I noticed a typo in the CSV spec: the type 'SingleNamespaceq' should be 'SingleNamespace' to match OLM’s supported types.
  • The dev-images make target is replacing 'registry.redhat.com' but everywhere else you use 'registry.redhat.io'—please align on the correct registry domain.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- I noticed a typo in the CSV spec: the type 'SingleNamespaceq' should be 'SingleNamespace' to match OLM’s supported types.
- The dev-images make target is replacing 'registry.redhat.com' but everywhere else you use 'registry.redhat.io'—please align on the correct registry domain.

## Individual Comments

### Comment 1
<location> `config/manifests/bases/model-validation-operator.clusterserviceversion.yaml:45` </location>
<code_context>
     type: OwnNamespace
   - supported: false
-    type: SingleNamespace
+    type: SingleNamespaceq
   - supported: false
     type: MultiNamespace
</code_context>

<issue_to_address>
Typo in 'SingleNamespaceq' should be 'SingleNamespace'.

This typo may prevent correct operator installation due to mismatched install mode.
</issue_to_address>

<suggested_fix>
<<<<<<< SEARCH
  - supported: false
    type: SingleNamespaceq
=======
  - supported: false
    type: SingleNamespace
>>>>>>> REPLACE

</suggested_fix>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@SequeI SequeI force-pushed the releaseStuff branch 3 times, most recently from 81b098e to 87943f8 Compare September 7, 2025 23:41
Signed-off-by: SequeI <asiek@redhat.com>
@SequeI SequeI merged commit 0573d7d into main Sep 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants