-
Notifications
You must be signed in to change notification settings - Fork 0
chore: release resources #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR prepares the operator for a v0.0.1 release by overhauling CSV metadata (version, maturity, annotations, provider) and standardizing image references to the Red Hat registry with digest support, plus adding a ‘dev-images’ Makefile helper. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- I noticed a typo in the CSV spec: the type 'SingleNamespaceq' should be 'SingleNamespace' to match OLM’s supported types.
- The dev-images make target is replacing 'registry.redhat.com' but everywhere else you use 'registry.redhat.io'—please align on the correct registry domain.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- I noticed a typo in the CSV spec: the type 'SingleNamespaceq' should be 'SingleNamespace' to match OLM’s supported types.
- The dev-images make target is replacing 'registry.redhat.com' but everywhere else you use 'registry.redhat.io'—please align on the correct registry domain.
## Individual Comments
### Comment 1
<location> `config/manifests/bases/model-validation-operator.clusterserviceversion.yaml:45` </location>
<code_context>
type: OwnNamespace
- supported: false
- type: SingleNamespace
+ type: SingleNamespaceq
- supported: false
type: MultiNamespace
</code_context>
<issue_to_address>
Typo in 'SingleNamespaceq' should be 'SingleNamespace'.
This typo may prevent correct operator installation due to mismatched install mode.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
- supported: false
type: SingleNamespaceq
=======
- supported: false
type: SingleNamespace
>>>>>>> REPLACE
</suggested_fix>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
config/manifests/bases/model-validation-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
81b098e
to
87943f8
Compare
Signed-off-by: SequeI <asiek@redhat.com>
Summary by Sourcery
Prepare the model-validation-operator for the 0.0.1-techpreview release by updating CSV metadata, switching default images to Red Hat registry digests, and adding a Makefile target for image overrides.
Enhancements:
Build:
Chores: