-
Notifications
You must be signed in to change notification settings - Fork 0
fix: point to correct dockerfile #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: SequeI <asiek@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts Tekton pipeline definitions to use the specialized Dockerfile for the model-validation operator by updating the 'dockerfile' parameter in both pull-request and push pipelines. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Add a pre-check step in your Tekton tasks to ensure Dockerfile.model-validation.rh exists, so the pipeline fails early if the filename is incorrect.
- Consider moving the Dockerfile filename into a shared parameter or variable to avoid duplicating and updating it in multiple pipeline definitions.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Add a pre-check step in your Tekton tasks to ensure Dockerfile.model-validation.rh exists, so the pipeline fails early if the filename is incorrect.
- Consider moving the Dockerfile filename into a shared parameter or variable to avoid duplicating and updating it in multiple pipeline definitions.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
PR Code Suggestions ✨No code suggestions found for the PR. |
6f3c9d5
to
ad4952a
Compare
/retest |
Summary by Sourcery
CI: