Skip to content

Conversation

SequeI
Copy link
Collaborator

@SequeI SequeI commented Sep 23, 2025

Summary by Sourcery

CI:

  • point Tekton pull-request and push pipelines to Dockerfile.model-validation.rh instead of the generic Dockerfile

Signed-off-by: SequeI <asiek@redhat.com>
Copy link

sourcery-ai bot commented Sep 23, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts Tekton pipeline definitions to use the specialized Dockerfile for the model-validation operator by updating the 'dockerfile' parameter in both pull-request and push pipelines.

File-Level Changes

Change Details Files
Point pipelines to the correct Dockerfile
  • Updated 'dockerfile' value in pull-request pipeline to Dockerfile.model-validation.rh
  • Updated 'dockerfile' value in push pipeline to Dockerfile.model-validation.rh
.tekton/model-validation-operator-pull-request.yaml
.tekton/model-validation-operator-push.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Consistency Check

Ensure the new dockerfile path Dockerfile.model-validation.rh actually exists at the repo root (or adjust path-context) and matches what the Tekton build task expects for its dockerfile param.

- name: dockerfile
  value: Dockerfile.model-validation.rh
- name: path-context
  value: .
Consistency Check

Verify the same dockerfile path resolution and task parameter compatibility in the push pipeline to avoid divergence between PR and push builds.

- name: dockerfile
  value: Dockerfile.model-validation.rh
- name: path-context
  value: .

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Add a pre-check step in your Tekton tasks to ensure Dockerfile.model-validation.rh exists, so the pipeline fails early if the filename is incorrect.
  • Consider moving the Dockerfile filename into a shared parameter or variable to avoid duplicating and updating it in multiple pipeline definitions.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Add a pre-check step in your Tekton tasks to ensure Dockerfile.model-validation.rh exists, so the pipeline fails early if the filename is incorrect.
- Consider moving the Dockerfile filename into a shared parameter or variable to avoid duplicating and updating it in multiple pipeline definitions.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

qodo-merge-pro bot commented Sep 23, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

Signed-off-by: SequeI <asiek@redhat.com>
@JasonPowr JasonPowr force-pushed the fix branch 2 times, most recently from 6f3c9d5 to ad4952a Compare September 25, 2025 09:38
@JasonPowr
Copy link

/retest

@JasonPowr JasonPowr merged commit c61d3fc into main Sep 26, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants