Use standart crypto library to generate certificates #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonPowr
approved these changes
Dec 4, 2023
|
holding off on merging - I'm seeing this with install - but will run again since it might be an issue on my end: If @JasonPowr or @osmman can install & confirm this is not an issue, please comment! |
sallyom
reviewed
Dec 4, 2023
osmman
force-pushed
the
cli-install-crypto
branch
from
f49aa8d
to
d00162f
Compare
|
Thank @sallyom for finding the bug. I fixed cause of the problem which was that I didn't encode the fulsio-root certificate into PEM format. |
|
I tested this, all works well now! |
sallyom
pushed a commit
that referenced
this pull request
Dec 7, 2023
sallyom
pushed a commit
that referenced
this pull request
Dec 10, 2023
sallyom
pushed a commit
that referenced
this pull request
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.