refactor: ♻️ move content into main.py, use scripts as functions
#29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonvago
requested changes
May 28, 2025
scripts/resource_properties.py
Outdated
| import seedcase_sprout as sp | ||
|
|
||
|
|
||
| def resource_properties_seed_beetles(): |
There was a problem hiding this comment.
Does this need to be a function?
There was a problem hiding this comment.
Hm, I guess not. I didn't immediately think that variables can be called from other scripts.
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
signekb
reviewed
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Something has been bugging me for a while with our potential workflow, especially around the resources. One idea could be that we use
main.pyin the parent folder to coordinate all the tasks, and keep thescriptsto hold the python functions that are used inmain.py. Then we can simplify towrite_properties(),read_properties()and no updating function. And we use thePackagePropertiesinmain.pyas the source of truth for the properties.Then we can make templates to create a script of the extracted resource properties as functions.
This PR needs an in-depth review.