refactor: ♻️ update with newest changes to Sprout #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the data's documentation found on Zenodo.
Based on the data documentation on Zenodo. When the description was the same (except for casing) as the field name, only `title` was filled out.
….py` Rerunning `main.py` with these changes adds the resource properties to `datapackage.json` and `README.md`.
This adds a the tidied data as a parquet file in a newly created folder structure under `resources/`.
signekb
commented
Jul 22, 2025
martonvago
reviewed
Jul 22, 2025
Co-authored-by: martonvago <57952344+martonvago@users.noreply.github.com>
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
1 task
signekb
added a commit
that referenced
this pull request
Jul 23, 2025
# Description Since the folder where the downloaded and cleaned data will be in is now called `raw/`, see #47. This PR needs a no review. ## Checklist - [X] Ran `just run-all`
… references in `main.py`
…nning `main.py` Fixes indents in `package.description`
Since we don't operate with a "core" of `seedcase-sprout` anymore.
|
After the merge of seedcase-project/seedcase-sprout#1488, we can get the indents in the resource and field descriptions removed from |
lwjohnst86
requested changes
Jul 23, 2025
Removing `seed-beetle-` from the resource name. Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
Removing `seed-beetle`
lwjohnst86
approved these changes
Jul 24, 2025
github-project-automation
bot
moved this from In Progress
to Done
in Iteration planning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #35
Closes #13
Closes #12
Closes #32 (did everything through GenomeDK 🎉 )
I've encountered a few things that I think we should change and/or add to Sprout based on this work. I've added them as issues in the
seedcase-sproutrepo:descriptionin output ofas_readme_textseedcase-sprout#1475README.mdseedcase-sprout#1477write_resource_batch()is rerun withmain.pyseedcase-sprout#1478properties.pypackage_properties.pyinstead seedcase-sprout#1480This PR needs a quick/an in-depth review.
Checklist
just run-all(nottypossince it's not configured yet)