Skip to content

Conversation

lwjohnst86
Copy link
Member

Description

This tests that copying also fixes deleted files or can be used in an existing project.

Closes #122

This PR needs an in-depth review.

Checklist

  • Ran just run-all

Copy link
Contributor

@martonvago martonvago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions and a typo ☺️

justfile Outdated
echo "Testing recopy command -----------"
rm .cz.toml
git add .
git commit -m "test: recopying from the template"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit just deletes .cz.toml, right? Or how is it testing the recopying? Or is it to say that it like sets up the test to come?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only deleted one file to show that it gets added back to confirm the recopy works. We could add more files to delete.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was just wondering about the commit message vs the content of the commit. But it doesn't really matter 👍 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooo, I see what you mean. Yea, It's more of a way to indicate the state. I will clarify the message.

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Jul 25, 2025
Co-authored-by: martonvago <57952344+martonvago@users.noreply.github.com>
@lwjohnst86 lwjohnst86 requested a review from martonvago July 25, 2025 15:13
@lwjohnst86 lwjohnst86 moved this from In Progress to In Review in Iteration planning Jul 25, 2025
martonvago
martonvago previously approved these changes Jul 25, 2025
justfile Outdated
echo "Testing recopy command -----------"
rm .cz.toml
git add .
git commit -m "test: recopying from the template"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was just wondering about the commit message vs the content of the commit. But it doesn't really matter 👍 👍

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Jul 25, 2025
@lwjohnst86 lwjohnst86 requested a review from martonvago July 25, 2025 15:24
@lwjohnst86 lwjohnst86 merged commit 17cabfc into main Jul 25, 2025
4 of 5 checks passed
@lwjohnst86 lwjohnst86 deleted the build/add-testing-of-recopy-and-existing-project branch July 25, 2025 15:25
@github-project-automation github-project-automation bot moved this from In Progress to Done in Iteration planning Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Test in justfile that checks how update/recopy works

2 participants