Skip to content

build: 🔧 update config for non-template package #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2025

Conversation

martonvago
Copy link
Contributor

Description

This PR updates config files for the non-template project.

This PR needs an in-depth review.

Checklist

@martonvago martonvago self-assigned this Aug 4, 2025
@martonvago martonvago marked this pull request as ready for review August 4, 2025 16:24
@martonvago martonvago requested a review from a team as a code owner August 4, 2025 16:24
@martonvago martonvago moved this from Todo to In Review in Iteration planning Aug 4, 2025
@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Aug 5, 2025
@lwjohnst86
Copy link
Member

Since this PR doesn't modify the "source" files, it would be chore: :wrench: or similar. Or build:

@lwjohnst86 lwjohnst86 changed the title refactor: ♻️ update config for non-template package build: 🔧 update config for non-template package Aug 5, 2025
Comment on lines +24 to +29
update-template:
cp .cz.toml .pre-commit-config.yaml .typos.toml .editorconfig template/
mkdir -p template/tools
cp tools/get-contributors.sh template/tools/
cp .github/pull_request_template.md template/.github/
cp .github/workflows/build-website.yml .github/workflows/dependency-review.yml template/.github/workflows/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only bit I changed from the template-website version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build website workflow may need to be removed. But we can deal with that later, as you add the copier.yaml file and the questions in it.

Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
@martonvago martonvago requested a review from lwjohnst86 August 5, 2025 10:46
@martonvago martonvago moved this from In Progress to In Review in Iteration planning Aug 5, 2025
Comment on lines +24 to +29
update-template:
cp .cz.toml .pre-commit-config.yaml .typos.toml .editorconfig template/
mkdir -p template/tools
cp tools/get-contributors.sh template/tools/
cp .github/pull_request_template.md template/.github/
cp .github/workflows/build-website.yml .github/workflows/dependency-review.yml template/.github/workflows/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build website workflow may need to be removed. But we can deal with that later, as you add the copier.yaml file and the questions in it.

@lwjohnst86 lwjohnst86 merged commit 096781a into main Aug 5, 2025
5 checks passed
@lwjohnst86 lwjohnst86 deleted the refactor/non-template-config branch August 5, 2025 10:53
@github-project-automation github-project-automation bot moved this from In Review to Done in Iteration planning Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants