-
Notifications
You must be signed in to change notification settings - Fork 0
feat: ✨ add files with copier variables #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8989e5c
to
865a4c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start! Some comments
.vscode/settings.json
Outdated
@@ -30,6 +30,7 @@ | |||
"python.languageServer": "Pylance", | |||
"files.insertFinalNewline": true, | |||
"files.associations": { | |||
"justfile.jinja": "django-txt", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is that? django-txt
? Does that include a dependency on Django in some way? And why Django?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you happen to have a Django template extension, it gives nicer syntax highlighting than plaintext
, otherwise defaults to plaintext
. But you're right, we should just put plaintext
. I couldn't find a better jinja-
one. (The one it chooses automatically autoformats the file in a bad way.)
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
…oject/template-python-package into feat/template-variable-files
Oh I see: sometimes running |
@martonvago I noticed that too. Because it is a shell script, if there is an error at some point, it keeps going. So that means committing things even if the |
Ah makes sense, I'll have a think too |
project: | ||
type: website | ||
# Delete auto-generated files from `quartodoc` | ||
post-render: rm -f docs/reference/*.qmd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that this doesn't work, I think Quarto turns off the use of rm
in post-rendering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a decent amount of this that could be updated based on what we've learned in template-website
. But it's been long living enough here, so I'll merge it in.
Thanks! Yeah, I thought it would be easier to update once this is merged in |
Description
This PR adds
copier.yaml
and template files that depend on it.Some related config is also tidied up.
Closes #33
Checklist
just run-all