Skip to content

feat: ✨ add files with copier variables #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Aug 8, 2025

Conversation

martonvago
Copy link
Contributor

Description

This PR adds copier.yaml and template files that depend on it.
Some related config is also tidied up.

Closes #33

Checklist

  • Added or updated tests
  • Updated documentation
  • Ran just run-all

@martonvago martonvago force-pushed the feat/template-variable-files branch from 8989e5c to 865a4c5 Compare August 5, 2025 16:33
@martonvago martonvago moved this from Todo to In Review in Iteration planning Aug 5, 2025
@martonvago martonvago marked this pull request as ready for review August 5, 2025 16:53
@martonvago martonvago requested a review from a team as a code owner August 5, 2025 16:53
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start! Some comments

@@ -30,6 +30,7 @@
"python.languageServer": "Pylance",
"files.insertFinalNewline": true,
"files.associations": {
"justfile.jinja": "django-txt",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is that? django-txt? Does that include a dependency on Django in some way? And why Django?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you happen to have a Django template extension, it gives nicer syntax highlighting than plaintext, otherwise defaults to plaintext. But you're right, we should just put plaintext. I couldn't find a better jinja- one. (The one it chooses automatically autoformats the file in a bad way.)

@martonvago
Copy link
Contributor Author

Oh I see: sometimes running just test actually commits those commits... Not sure when though 🤔

@martonvago martonvago requested a review from lwjohnst86 August 6, 2025 11:14
@lwjohnst86
Copy link
Member

@martonvago I noticed that too. Because it is a shell script, if there is an error at some point, it keeps going. So that means committing things even if the cd doesn't work. I don't know a way around that though.

@martonvago
Copy link
Contributor Author

Ah makes sense, I'll have a think too

@martonvago martonvago moved this from In Progress to In Review in Iteration planning Aug 7, 2025
project:
type: website
# Delete auto-generated files from `quartodoc`
post-render: rm -f docs/reference/*.qmd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that this doesn't work, I think Quarto turns off the use of rm in post-rendering.

lwjohnst86
lwjohnst86 previously approved these changes Aug 8, 2025
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a decent amount of this that could be updated based on what we've learned in template-website. But it's been long living enough here, so I'll merge it in.

@lwjohnst86 lwjohnst86 merged commit ec38631 into main Aug 8, 2025
3 of 4 checks passed
@lwjohnst86 lwjohnst86 deleted the feat/template-variable-files branch August 8, 2025 07:16
@github-project-automation github-project-automation bot moved this from In Review to Done in Iteration planning Aug 8, 2025
@martonvago
Copy link
Contributor Author

There's a decent amount of this that could be updated based on what we've learned in template-website. But it's been long living enough here, so I'll merge it in.

Thanks! Yeah, I thought it would be easier to update once this is merged in ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Convert repo into a copier format
2 participants