Skip to content

Conversation

lwjohnst86
Copy link
Member

Description

This PR removes the reset-local, it wasn't working as I thought.

This PR needs a quick review.

@lwjohnst86 lwjohnst86 self-assigned this Jan 3, 2025
@lwjohnst86 lwjohnst86 requested a review from signekb January 6, 2025 09:17
@lwjohnst86 lwjohnst86 enabled auto-merge (squash) January 6, 2025 09:17
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 👍 @lwjohnst86 How did you expect it to work?

@lwjohnst86 lwjohnst86 merged commit bdd5073 into main Jan 6, 2025
@lwjohnst86 lwjohnst86 deleted the build/remove-recipe-from-justfile branch January 6, 2025 09:36
@lwjohnst86
Copy link
Member Author

I was hoping to use it to clean up any left over files from different builds, because there was a few times I had an issue that was fixed after removing some of these files. But the different build files weren't always the issue, nor was the pattern matching able to get everything that needed to be removed without affecting other files.

Plus, it was to remove any left over autogenerated files from the Python code in the website when we were using SPROUT_ROOT rather than assume everything is working directory. Which we don't do anymore.

Basically, I think there are better solutions to the (rare) issue but it's very low priority right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants