Should not allow setting both duration and end_time

[dlee]

Schedule should not allow setting both duration and end_time.

[jfelchner]

Really? Do you honestly think that this is enough information for anyone to be able to fulfill this issue?

How about an explanation?

I'm going to just guess what you're talking about here: The end_time is not the end time of the occurrence, it's the end time of the schedule. The duration describes how long each occurrence happens for. Hence they are two distinct things.

[dlee]

@jfelchner end_time should be the end time of first occurrence. If you set both duration and end_time, they are in conflict. Even if end_time was the end time of the schedule (which would be the end time of the last occurrence in the schedule), wouldn't that be in conflict?

[jfelchner]

@dlee You are correct.

schedule          = IceCube::Schedule.new Time.utc(2012, 10, 1, 12, 0, 0)
schedule.end_time = Time.utc(2012, 12, 1, 12, 0, 0)
schedule.duration = 3600

schedule.to_ical

#=> DTSTART:20121001T120000Z\nDURATION:PT1H\nDTEND:20121201T120000Z

According to the iCal spec, DTEND is the end time of the first occurrence and is what the duration is calculated from:

The "DTSTART" and "DTEND" property pair or "DTSTART" and "DURATION" property pair, specified within the iCalendar object defines the first instance of the recurrence.

Therefore they should be mutually exclusive.

[jfelchner]

Additionally I feel as though calling Schedule#duration when #end_time has been set, should return the calculated duration rather than returning nil.

[avit]

@dlee it looks like your issues are all follow-ups to the changes introduced in #99. I have some fixes for it in my fork, can we get some consensus on the proposed changes?

• Should one of end_time= or duration= be deprecated?
• If we keep both, which one should have precedence?
• Should to_ical output DTEND or DURATION?

In my current version:

• Accessors for both are still available.
• Preference is given to :end_time in options
• Only DTEND is output to ical, and only :end_time to_hash