[WIP] Revive android auto #836

morckx · 2020-05-21T20:36:45Z

What again were the issues Google had with our android auto support?
For me, it seems to work quite well.

i.e. without regressions concerning segler-alex#724 and segler-alex#725

werman · 2020-05-21T20:38:15Z

The needed voice search support.

morckx · 2020-05-21T20:42:13Z

The needed voice search support.

Ah, thanks. I think I had got that working, too, some time ago. I hope I'll find my changes again. One of them are already i here (6812455 ).

morckx · 2020-05-22T19:11:01Z

The needed voice search support.

See #389

OK, playFromSearch is already working – tested with android-media-controller.

The most important thing that is still missing to get through the tests is probably a default station, which is played whenever nothing is found. Especially of course if RadioDroid has just been installed and there are no favorites and no history yet.

Maybe BBC World News? Or is there anything even less controversial and more generic?

Of course it would be nice if the Voice Search would also search the server before it takes the default station (if it doesn't find anything in History and Favorites). For this purpose it would be handy to have a static function in Utils for server requests.

In addition, MediaStore.INTENT_ACTION_MEDIA_PLAY_FROM_SEARCH should apparently also be intercepted by the activity: https://developer.android.com/guide/components/intents-common.html#PlaySearch
I don't if that's really necessary, but it would be easy in any case.

werman · 2020-05-22T21:46:34Z

Thanks, I'll try to check soon.

Maybe BBC World News? Or is there anything even less controversial and more generic?

I think some plain music station would be better since it would be language independent.

werman · 2020-05-23T11:05:21Z

I remember I was able to test it in the emulator, now I'm not for some reason....

Are you able to test it with in emulators?

morckx · 2020-05-23T13:02:07Z

I remember I was able to test it in the emulator, now I'm not for some reason....

Are you able to test it with in emulators?

Yes, I just had to copy libcrypto.so.1.0.0 and libssl.so.1.0.0 from an old computer to
/usr/local/lib64/ and added a file /etc/ld.so.conf.d/local.conf with just /usr/local/lib64 in it, after that ldconfig and it worked. In case this was your problem. And don't forget to start the head unit server from android auto (Settings->Overflow Menu->Start Head Unit Server).

Ah if you meant install Android Auto on the emulator: No I haven't managed to do it, but tried it only briefly.

werman

Ok, it works with real Android device.

What I think is necessary:

Prev/Next should work for History and not only for favourites. And potentially with other lists.
If there is a station with broken icon url - it should not make us wait for 2s timeout on every navigation to a list with this station. I think it could be done on OkHttp level, with some interceptor, but...

app/src/main/AndroidManifest.xml

RadioDroid does not run on the head unit.

To make sure that even on first start onPlayFromSearch does not fail completely.

Run in Android Studio or with ./gradlew connectedCheck Unit tests with Mockito would be quicker, but also a lot messier in this case.

morckx · 2020-05-23T21:22:46Z

Ok, it works with real Android device.

What I think is necessary:

Prev/Next should work for History and not only for favourites. And potentially with other lists.
Right.

If there is a station with broken icon url - it should not make us wait for 2s timeout on every navigation to a list with this station. I think it could be done on OkHttp level, with some interceptor, but...

Yes, and there are some more little stability issues.

werman · 2020-05-23T21:28:09Z

Your instrumentation tests would clash with mine #654, better to add them afterwards.

werman · 2020-05-23T21:39:01Z

It wouldn't be hard for me to merge it together, but you are using junit5 and I've made all tests junit4, if you have any objects, could you write them in the #654? I just find instrumented tests being a bit fragile in terms of "why this test doesn't run from IDE today???", so making them junit5 adds another layer of things to go wrong. And I had enough of headache even with current setup.

morckx

It wouldn't be hard for me to merge it together, but you are using junit5 and I've made all tests junit4, if you have any objects, could you write them in the #654? I just find instrumented tests being a bit fragile in terms of "why this test doesn't run from IDE today???", so making them junit5 adds another layer of things to go wrong. And I had enough of headache even with current setup.

OK, we can sort this out later, I think. I can revert my instrumentation tests for now. I've used juni5 because I also used it already for the IcyDataSource unit tests.
I could also convert the test here to a unit test with Mockito, but it's probably not worth the mess and I'll rather have a look at #654.

EDIT: There is also a junit4 compatibility library for junit5 that we can give a try then.

morckx · 2020-05-23T21:26:32Z

app/src/main/res/raw/fallback_stations.json

+      "tags" : "news",
+      "url" : "http://bbcwssc.ic.llnwd.net/stream/bbcwssc_mp1_ws-einws",
+      "votes" : 123
+   }


Let's add some more stations here. Some criteria are probably:

ideally public

ideally receivable from all over the world

only music or in English

segler-alex · 2020-05-23T22:17:51Z

instead of having a list of fallback streams, why not play a prerecorded message to the user that a stream needs to be selected first. we could also use text to speech, that way we could even add it to the translatable strings.

morckx · 2020-05-23T22:27:36Z

instead of having a list of fallback streams, why not play a prerecorded message to the user that a stream needs to be selected first. we could also use text to speech, that way we could even add it to the translatable strings.

Yes, I thought about that, too. I just wanted to have the fallback station(s) first, because that's probably the easiest way to the Android Auto approval.

I would then definitely continue with messages via TTS. We could just send the toasts that we're issuing now (depending on the settings) via TTS. We already have many translations for these.

Wait for segler-alex#654 fisrt and merge later. This reverts commit df0e079.

The played time display seems to stay 00:00 unless MediaMetadataCompat.METADATA_KEY_DURATION is set (to unknown/infinity in our case).

See https://github.com/googlesamples/android-media-controller All basic tests and most android auto tests do pass, now.

app/src/main/java/net/programmierecke/radiodroid2/service/RadioDroidBrowser.java

According to android-media-controller auto test suite¹, icon bitmaps for the media browser must be null and icon uris are restricted to content uris and android resources. So there is no supported way of using icons here. However, icons in the browser are extremely helpful, especially while driving and network use is also no issue in this case – and the icons work. Thus, introduce a settings and let the user decide. ¹https://github.com/googlesamples/android-media-controller/blob/0bbad7b22ca2c087629cce0e5b0eb61f07f3fde1/mediacontroller/src/main/java/com/example/android/mediacontroller/MediaAppTestDetails.kt#L1226

Set grid mode when showing icons is selected. Setting CONTENT_STYLE_SUPPORTED to true is necessary in any case to make the auto test suite happy and not crash.

zo-shin · 2020-05-30T11:32:58Z

app/src/main/java/net/programmierecke/radiodroid2/service/RadioDroidBrowser.java

+       if (showIconsInBrowser && sharedPref.getBoolean("settings_grid_style_hud_icon_display", false)) {
+           Log.d(TAG, "Setting grid style for playables");


Should it be "settings_grid_layout_hud_icon_display"? Or you have to rename the key in setting.

zo-shin · 2020-05-30T11:53:30Z

app/src/main/res/values/strings.xml

+    <string name="settings_grid_layout_hud_icon_display">Grid layout for station icons</string>
+    <string name="settings_grid_layout_hud_icon_display_desc_off">Stations are displayed in list layout</string>
+    <string name="settings_grid_style_layout_icon_display_desc_on">Station icons are displayed in grid layout</string>


When it is off, is the icon still shown? Should "icons" be added?

segler-alex · 2023-09-28T07:25:17Z

hi, if you are still interested. could you do another push that is not WIP? thank you for your work!!

segler-alex · 2023-10-16T11:35:55Z

in WIP too long, closing
please create another PR if you want to work on it.

morckx added 4 commits May 18, 2020 18:57

Remove voice search residues from play from search query

6812455

Advertise android auto support in Manifest

d213878

Re-enable RadioDroidBrowserService (properly)

00e1f5a

i.e. without regressions concerning segler-alex#724 and segler-alex#725

Do not advertise a top clicked list until we can offer it

6f84be3

werman reviewed May 23, 2020

View reviewed changes

app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved

morckx added 3 commits May 23, 2020 23:08

Do not advertise automotive support

db5f40f

RadioDroid does not run on the head unit.

Add fallback stations manager

cf37370

To make sure that even on first start onPlayFromSearch does not fail completely.

Add instrumentation tests for FallbackStationsManager

df0e079

Run in Android Studio or with ./gradlew connectedCheck Unit tests with Mockito would be quicker, but also a lot messier in this case.

morckx commented May 23, 2020

View reviewed changes

morckx added 4 commits May 24, 2020 09:44

Revert "Add instrumentation tests for FallbackStationsManager"

c69a78e

Wait for segler-alex#654 fisrt and merge later. This reverts commit df0e079.

Fix playback speed in mediaSession.setPlaybackState

de8d34e

Fix played time not updated in HUD

3ebb9c3

The played time display seems to stay 00:00 unless MediaMetadataCompat.METADATA_KEY_DURATION is set (to unknown/infinity in our case).

Fix most android auto test suite issues in PlayerService

95c7cb0

See https://github.com/googlesamples/android-media-controller All basic tests and most android auto tests do pass, now.

morckx force-pushed the revive-android-auto branch from 881064c to b455c8e Compare May 27, 2020 20:59

zo-shin reviewed May 28, 2020

View reviewed changes

app/src/main/java/net/programmierecke/radiodroid2/service/RadioDroidBrowser.java Outdated Show resolved Hide resolved

morckx force-pushed the revive-android-auto branch from b455c8e to e80427c Compare May 28, 2020 19:24

morckx added 3 commits May 28, 2020 22:40

Set browser style depending on icon settings

77199ac

Set grid mode when showing icons is selected. Setting CONTENT_STYLE_SUPPORTED to true is necessary in any case to make the auto test suite happy and not crash.

Add setting for grid/list style for playable in hud media browser

e9e5276

morckx force-pushed the revive-android-auto branch 2 times, most recently from 3f40514 to 5487435 Compare May 28, 2020 21:07

Stay in the same queue when skipping to next/previous

0b12c92

morckx force-pushed the revive-android-auto branch from 5487435 to 0b12c92 Compare May 29, 2020 20:28

zo-shin reviewed May 30, 2020

View reviewed changes

Merge remote-tracking branch 'origin/master' into revive-android-auto

4545fe6

RobinEd mentioned this pull request Oct 5, 2023

Android Auto compatibility #1150

Open

segler-alex closed this Oct 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Revive android auto #836

[WIP] Revive android auto #836

morckx commented May 21, 2020

werman commented May 21, 2020 •

edited

Loading

morckx commented May 21, 2020

morckx commented May 22, 2020

werman commented May 22, 2020

werman commented May 23, 2020

morckx commented May 23, 2020 •

edited

Loading

werman left a comment •

edited

Loading

morckx commented May 23, 2020

werman commented May 23, 2020

werman commented May 23, 2020

morckx left a comment •

edited

Loading

morckx May 23, 2020

segler-alex commented May 23, 2020 •

edited

Loading

morckx commented May 23, 2020 •

edited

Loading

zo-shin May 30, 2020

zo-shin May 30, 2020

segler-alex commented Sep 28, 2023

segler-alex commented Oct 16, 2023

		if (showIconsInBrowser && sharedPref.getBoolean("settings_grid_style_hud_icon_display", false)) {
		Log.d(TAG, "Setting grid style for playables");

[WIP] Revive android auto #836

[WIP] Revive android auto #836

Conversation

morckx commented May 21, 2020

werman commented May 21, 2020 • edited Loading

morckx commented May 21, 2020

morckx commented May 22, 2020

werman commented May 22, 2020

werman commented May 23, 2020

morckx commented May 23, 2020 • edited Loading

werman left a comment • edited Loading

Choose a reason for hiding this comment

morckx commented May 23, 2020

werman commented May 23, 2020

werman commented May 23, 2020

morckx left a comment • edited Loading

Choose a reason for hiding this comment

morckx May 23, 2020

Choose a reason for hiding this comment

segler-alex commented May 23, 2020 • edited Loading

morckx commented May 23, 2020 • edited Loading

zo-shin May 30, 2020

Choose a reason for hiding this comment

zo-shin May 30, 2020

Choose a reason for hiding this comment

segler-alex commented Sep 28, 2023

segler-alex commented Oct 16, 2023

werman commented May 21, 2020 •

edited

Loading

morckx commented May 23, 2020 •

edited

Loading

werman left a comment •

edited

Loading

morckx left a comment •

edited

Loading

segler-alex commented May 23, 2020 •

edited

Loading

morckx commented May 23, 2020 •

edited

Loading