Skip to content

Coerce traits to String to fix issue #4 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 7, 2017
Merged

Coerce traits to String to fix issue #4 #9

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e79988f
Coerce traits to String to fix issue #4
Sep 5, 2017
e5d7c02
Enumerate on id key and id obj instead of NSString
Sep 6, 2017
c88983a
Removes unnecessary line
Sep 6, 2017
777e654
Refactor mapToStrings
Sep 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions Segment-Firebase/Classes/SEGFirebaseIntegration.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,23 @@

@implementation SEGFirebaseIntegration

#pragma mark - Helper Functions
+ (NSDictionary *)mapToStrings:(NSDictionary *)dictionary
{
NSMutableDictionary *output = [NSMutableDictionary dictionaryWithCapacity:dictionary.count];

[dictionary enumerateKeysAndObjectsUsingBlock:^(id key, id data, BOOL *stop) {
if ([data isKindOfClass:[NSString class]]) {
[output setObject:data forKey:key];
} else {
[output setObject:[NSString stringWithFormat:@"%@", data] forKey:key];
}
}];

return [output copy];
}


#pragma mark - Initialization

- (id)initWithSettings:(NSDictionary *)settings
Expand All @@ -29,8 +46,9 @@ - (void)identify:(SEGIdentifyPayload *)payload
[FIRAnalytics setUserID:payload.userId];
SEGLog(@"[FIRAnalytics setUserId:%@]", payload.userId);
}

[payload.traits enumerateKeysAndObjectsUsingBlock:^(id key, id obj, BOOL *stop){
// Firebase requires user properties to be a NSString
NSDictionary *mappedTraits = [SEGFirebaseIntegration mapToStrings:payload.traits];
[mappedTraits enumerateKeysAndObjectsUsingBlock:^(NSString *key, NSString *obj, BOOL *stop){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has the similar issue as https://github.com/segment-integrations/analytics-ios-integration-firebase/pull/9/files#r137339990

Copy link
Contributor Author

@ladanazita ladanazita Sep 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mappedTraits has run through mapToStrings, which returns a NSDictionary of key value pairs of type NSString. Also broken link?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. So using it as a NSString should be fine here then.

NSString *trait = [key stringByReplacingOccurrencesOfString:@" " withString:@"_"];
NSString *value = [obj stringByReplacingOccurrencesOfString:@" " withString:@"_"];
[FIRAnalytics setUserPropertyString:value forName:trait];
Expand Down