Skip to content

Conversation

varadarajan-tw
Copy link
Contributor

@varadarajan-tw varadarajan-tw commented Mar 24, 2025

Reverts #2799

Testing

Testing not required as this is a revert PR

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@varadarajan-tw varadarajan-tw merged commit 6a93b4f into main Mar 24, 2025
12 checks passed
@varadarajan-tw varadarajan-tw deleted the snap-conversions-revert branch March 24, 2025 13:15
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.98%. Comparing base (11b02e8) to head (9542dc4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...versions-api/reportConversionEvent/snap-capi-v3.ts 96.42% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2823      +/-   ##
==========================================
+ Coverage   77.97%   77.98%   +0.01%     
==========================================
  Files        1042     1042              
  Lines       19016    19008       -8     
  Branches     3706     3697       -9     
==========================================
- Hits        14827    14823       -4     
+ Misses       2886     2885       -1     
+ Partials     1303     1300       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

julesbravo pushed a commit to Stodge-Inc/segment-destination that referenced this pull request Mar 28, 2025
davidbielik pushed a commit to davidbielik/action-destinations that referenced this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants