Skip to content

Conversation

abhandage
Copy link
Contributor

@abhandage abhandage commented Jun 11, 2025

This pull request introduces a new destination integration for Google Data Manager, including its configuration, actions. The integration supports two actions: ingest and remove, along with OAuth2 authentication.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link
Contributor

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Google Data Manager, Settings:

Add these new fields as optional instead and assume default values in perform or performBatch block.

Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.98%. Comparing base (47dbf4a) to head (eae4fb9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2986      +/-   ##
==========================================
+ Coverage   77.97%   77.98%   +0.01%     
==========================================
  Files        1083     1086       +3     
  Lines       20047    20062      +15     
  Branches     3863     3864       +1     
==========================================
+ Hits        15631    15646      +15     
  Misses       3109     3109              
  Partials     1307     1307              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@abhandage abhandage marked this pull request as ready for review June 11, 2025 07:30
@abhandage abhandage requested a review from a team as a code owner June 11, 2025 07:30
@abhandage abhandage requested a review from varadarajan-tw June 11, 2025 07:37
@abhandage abhandage merged commit 8f3005d into main Jun 11, 2025
14 checks passed
@abhandage abhandage deleted the STRATCONN-5870-google-data-manager-bootup branch June 11, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants