Skip to content

Conversation

rvadera12
Copy link
Contributor

@rvadera12 rvadera12 commented Jun 20, 2025

We are planning to release the Twilio Messaging Destination to a private beta. This PR makes updates to the original POC after getting feedback from the Twilio Team. This PR also adds unit tests. There is some RCS functionality however will be hidden from the customers until the public beta or GA. _

Testing

Testing Doc: https://docs.google.com/document/d/1Go9ijHDntBwXcvpM13kMNE9GZyrdBFsjTBKMbug4bUk/edit?usp=sharing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@rvadera12 rvadera12 changed the title wip Twilio Destination Updates Jun 20, 2025
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 68.42105% with 12 lines in your changes missing coverage. Please review.

Project coverage is 78.02%. Comparing base (3c6b927) to head (d96ac99).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ons/twilio-messaging/sendMessage/dynamic-fields.ts 53.84% 2 Missing and 4 partials ⚠️
...destinations/twilio-messaging/sendMessage/utils.ts 75.00% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3016      +/-   ##
==========================================
- Coverage   78.04%   78.02%   -0.02%     
==========================================
  Files        1099     1107       +8     
  Lines       20231    20459     +228     
  Branches     3894     3946      +52     
==========================================
+ Hits        15789    15963     +174     
- Misses       3126     3151      +25     
- Partials     1316     1345      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a js script rather than a jest test as other unit tests generally are?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was playing around with Open AI tests and it wrote it in JS script. I just removed the file, I didn't mean to include it in the commit.

nick-Ag
nick-Ag previously approved these changes Jun 23, 2025
@joe-ayoub-segment
Copy link
Contributor

hi @rvadera12 approved. I'll deploy this today.
QQ - what were the changes for mediaUrl and inline template about? What's the difference in functionality vs the older code?

@joe-ayoub-segment joe-ayoub-segment merged commit df725e0 into main Jun 24, 2025
12 of 14 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the twilio-messaging-destination-updates branch June 24, 2025 14:12
@joe-ayoub-segment
Copy link
Contributor

hi @rvadera12 deployed and pushed.

kc-ong-taguchi pushed a commit to kc-ong-taguchi/action-destinations that referenced this pull request Aug 5, 2025
* wip

* remove facebook messenger

* types

* wip

* remove inline variables

* wip

* add unit tests

* wip

* validation errors

* debug tests

* Update fields.ts

* Delete packages/destination-actions/src/destinations/twilio-messaging/sendMessage/test-rcs-inline.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants