-
Notifications
You must be signed in to change notification settings - Fork 282
Twilio Destination Updates #3016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twilio Destination Updates #3016
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3016 +/- ##
==========================================
- Coverage 78.04% 78.02% -0.02%
==========================================
Files 1099 1107 +8
Lines 20231 20459 +228
Branches 3894 3946 +52
==========================================
+ Hits 15789 15963 +174
- Misses 3126 3151 +25
- Partials 1316 1345 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a js script rather than a jest test as other unit tests generally are?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was playing around with Open AI tests and it wrote it in JS script. I just removed the file, I didn't mean to include it in the commit.
…/sendMessage/test-rcs-inline.js
hi @rvadera12 approved. I'll deploy this today. |
hi @rvadera12 deployed and pushed. |
* wip * remove facebook messenger * types * wip * remove inline variables * wip * add unit tests * wip * validation errors * debug tests * Update fields.ts * Delete packages/destination-actions/src/destinations/twilio-messaging/sendMessage/test-rcs-inline.js
We are planning to release the Twilio Messaging Destination to a private beta. This PR makes updates to the original POC after getting feedback from the Twilio Team. This PR also adds unit tests. There is some RCS functionality however will be hidden from the customers until the public beta or GA. _
Testing
Testing Doc: https://docs.google.com/document/d/1Go9ijHDntBwXcvpM13kMNE9GZyrdBFsjTBKMbug4bUk/edit?usp=sharing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.